Review main Merged

89641[TASK] Resolve two group/select related scenario todos

Christian Kuhn CR +2 V +2 Easy +7 −2 updated 06/05/25, 15:03

Commit message

TCA setting 'localizeReferencesAtParentLocalization' on type=group
and type=select fields allows to localize a sibling upon localizing
a related record.

In contrast to simple type=inline configurations that represent a
parent-child relation, type=group and select represent 'sibling'
relations (two persons may have the same sister). It
is a nice usability asset that siblings can be auto-localized when
localizing a referencing record. Patch #41713 looked at this detail
and left two todo comments questioning the discard and publish
behavior.

Looking at these comments, we now clarify the behavior. When some
sibling triggered the localization of a group or select related
record, we should not discard or publish these localized records
when the related record is discarded or published. Such siblings
need to be actively selected to be discarded or published by
editors even if they have been auto-created since we can never
know which other potential sibling may have created the overlay:
Auto discarding or publishing siblings may change the relation
integrity of other records unintentionally.

The patch turns the todo questioning this behavior into a comment
declaring it as intended.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Christian Kuhn uploaded patch set 1 06/05/25, 11:00

  2. Christian Kuhn updated the commit message in patch set 2 06/05/25, 11:02

  3. Christian Kuhn updated the commit message in patch set 3 06/05/25, 11:08

  4. core-ci voted on patch set 1 V +1 06/05/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79917

  5. core-ci voted on patch set 2 V +1 06/05/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79918

  6. core-ci voted on patch set 3 V +1 06/05/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79919

  7. Garvin Hicking commented on patch set 3 CR +1 V +1 06/05/25, 11:33

    lgtm
  8. Benni Mack voted on patch set 3 CR +1 V +1 06/05/25, 11:43

  9. Benni Mack commented on patch set 3 06/05/25, 11:44

    Instead of a sibilng relation, I think the term we're looking for is a "loose relationship" (every entity can live on their own), whereas type=inline is obviously a strong relationship (a hotel room cannot exist without its hotel ;))
  10. Christian Kuhn commented on patch set 3 06/05/25, 11:57

    Reply

    yeah. not 100% sure about wording. i selected 'sibling' since two such tables are 'the same level' *and* are related via group/select. but i think its quite clear on reading what is meant in this case and would keep this wording for now.
  11. Christian Kuhn voted on patch set 3 CR +2 V +2 06/05/25, 13:00

  12. Christian Kuhn merged patch set 4 06/05/25, 15:03