89641[TASK] Resolve two group/select related scenario todos
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesDiscard/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+4 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublish/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+3 −1
Review log 912
-
Christian Kuhn uploaded patch set 1 06/05/25, 11:00
-
Christian Kuhn updated the commit message in patch set 2 06/05/25, 11:02
-
Christian Kuhn updated the commit message in patch set 3 06/05/25, 11:08
-
core-ci voted on patch set 1 V +1 06/05/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79917
-
core-ci voted on patch set 2 V +1 06/05/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79918
-
core-ci voted on patch set 3 V +1 06/05/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79919
-
Garvin Hicking commented on patch set 3 CR +1 V +1 06/05/25, 11:33
lgtm -
Benni Mack voted on patch set 3 CR +1 V +1 06/05/25, 11:43
-
Benni Mack commented on patch set 3 06/05/25, 11:44
Instead of a sibilng relation, I think the term we're looking for is a "loose relationship" (every entity can live on their own), whereas type=inline is obviously a strong relationship (a hotel room cannot exist without its hotel ;)) -
Christian Kuhn commented on patch set 3 06/05/25, 11:57
Reply
yeah. not 100% sure about wording. i selected 'sibling' since two such tables are 'the same level' *and* are related via group/select. but i think its quite clear on reading what is meant in this case and would keep this wording for now. -
Christian Kuhn voted on patch set 3 CR +2 V +2 06/05/25, 13:00
-
Christian Kuhn merged patch set 4 06/05/25, 15:03