Review main Merged

89642[DOCS] Fix not displaying Changelog entry for 106743-SudoMode

Garvin Hicking CR +2 V +2 Easy +6 −1 updated 10/22/25, 13:28

Commit message

Since the ReST file for #106743 is labelled "Feature", it was
not displayed in the "12.4.x" structure [1].

This patch inserts the toc tree also for "features" in the
12.4.x release branch so it can be rendered and included
without errors.

[1] https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.4.x/Index.html

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Lina Wolf +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benjamin Franzke +1
    • Lina Wolf +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1213

  1. Garvin Hicking uploaded patch set 1 06/05/25, 11:42

  2. core-ci voted on patch set 1 V +1 06/05/25, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79920

  3. Lina Wolf commented on patch set 1 CR +1 V +1 06/05/25, 12:02

    Good Catch
  4. Christian Kuhn commented on patch set 1 06/05/25, 15:05

    that file should have been an important.rst ...
  5. Garvin Hicking commented on patch set 1 06/05/25, 15:25

    Reply

    yeah... renaming it means we would need redirects, that's always a bit annoying...
  6. Lina Wolf commented on patch set 1 06/05/25, 15:35

    Redirects are no problem I can create them on intercept and permalinks can stay the same
  7. Garvin Hicking commented on patch set 1 06/10/25, 07:23

    State of this: Different opinions on whether we should a.) Use this "adding" to show 12.4.x features and keep the feature rst in place b.) Rename the "feature" rst to "important", adding redirects, making a "feature" a "non-feature" Personally I'm leaning towards a.) to keep extra work sane, but I can understand b.) #needs-executive-decission ;)
  8. Benjamin Franzke voted on patch set 1 CR +1 V +1 06/10/25, 07:25

  9. Benjamin Franzke commented on patch set 1 06/10/25, 07:47

    Reply

    Important.rst is something that is important for an integrator to read. This is *not* important, it's a feature for some extensions to allow hooking into the sudo mode process. This is actually a Feature, that was added (yes it's a semver violation) in a bugfix release… So yes, let's go with a) Thanks!
  10. Oliver Hader voted on patch set 1 CR +1 V +1 06/10/25, 07:48

  11. Garvin Hicking commented on patch set 1 CR +2 V +2 06/10/25, 07:51

    Thanks for the feedback. To get it into a release, I'm merging it now.
  12. Garvin Hicking merged patch set 2 06/10/25, 08:06

  13. Lina Wolf commented on patch set 2 10/22/25, 13:28

    Reply

    I agree