Review 12.4 Merged

89644[BUGFIX] Fix URL parsing in UrlSoftReferenceParser

Benni Mack CR +2 V +2 Normal +78 −27 updated 06/05/25, 12:04

Commit message

The regular expression in UrlSoftReferenceParser
had four capture groups, but the code did expect five
groups, which ended up in unexpected results that
are now covered by tests.
Besides that, multiple URLs in a line could not be
detected properly due to the usage of preg_split().
With the usage of preg_match_all(), we can now get
multiple URLs in a line.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 06/05/25, 11:45

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 06/05/25, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79922

  3. Benni Mack voted on patch set 1 CR +2 V +2 06/05/25, 12:04

  4. Benni Mack merged patch set 2 06/05/25, 12:04