Review main Merged

89650[BUGFIX] Set datatype of sys_file:size to BIGINT 20

Stefan Froemken CR +2 V +2 Easy +10 −8 updated 07/29/25, 11:49

Commit message

Increase `sys_file.size` column type to `bigint(20)` to accommodate
larger file sizes, aligning with sizes used in earlier TYPO3 versions.

Tests are adopted because due to DB migrations the order of fields
matters in the Flexform XML.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1723

  1. Stefan Froemken uploaded patch set 1 06/05/25, 16:25

  2. Stefan Froemken updated the commit message in patch set 2 06/05/25, 16:27

  3. core-ci voted on patch set 1 V -1 06/05/25, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79941

  4. core-ci voted on patch set 2 V -1 06/05/25, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79942

  5. Garvin Hicking commented on patch set 2 CR -1 06/05/25, 18:37

    I would like to not populate ext_tables.sql with new entries. Instead we should enhance `typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php` and operate on type=number to allow defining the size. We could probably utilize the range.upper TCA configuration attribute here, and if it's a number > INT then use BIGINT instead. What do you think?
  6. Garvin Hicking updated the commit message in patch set 3 CR -1 V -1 06/05/25, 18:39

  7. core-ci voted on patch set 3 V -1 06/05/25, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79949

  8. Stefan Froemken commented on patch set 3 06/05/25, 19:24

    Reply

    > I would like to not populate ext_tables.sql with new entries. > > Instead we should enhance `typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php` and operate on type=number to allow defining the size. > > We could probably utilize the range.upper TCA configuration attribute here, and if it's a number > INT then use BIGINT instead. > > What do you think? Solve it like however you want. I'm open for everything. And it's not the only column which changes. See fe_users:image column. It was tinytext before and is now INT 10. I got the information that a patch for that issue may not be backported to TYPO3 13. At least these two columns are broken in TYPO3 13 and there should be a solution to solve that also for 13. Sure, for my extensions I have found a solution, and I also found a solution for the fe_users-importer of a customers project.
  9. Garvin Hicking commented on patch set 3 06/06/25, 08:34

    I've asked for more feedback on it. I'm retracting my -1 and am fine with whatever decision made.
  10. Garvin Hicking commented on patch set 3 CR +1 V +1 07/29/25, 08:56

    Reply

    Done
    Let's get this fixed the easy way for now
  11. Garvin Hicking rebased onto patch set 4 CR +1 V +1 07/29/25, 09:10

  12. Garvin Hicking updated the commit message in patch set 5 07/29/25, 09:12

  13. Garvin Hicking voted on patch set 5 CR +1 V +1 07/29/25, 09:13

  14. core-ci voted on patch set 4 V -1 07/29/25, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82472

  15. core-ci voted on patch set 5 V -1 07/29/25, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82473

  16. Garvin Hicking commented on patch set 5 CR 0 V 0 07/29/25, 09:36

    f'in fixtures 😂
  17. Garvin Hicking uploaded patch set 6 V -1 07/29/25, 10:00

    Tests
  18. core-ci voted on patch set 6 V +1 07/29/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82479

  19. Oliver Klee voted on patch set 6 CR +1 07/29/25, 10:10

  20. Garvin Hicking voted on patch set 6 CR +1 V +1 07/29/25, 10:12

  21. Christian Kuhn voted on patch set 6 CR +1 V +1 07/29/25, 11:02

  22. Garvin Hicking voted on patch set 6 CR +2 V +2 07/29/25, 11:41

  23. Garvin Hicking merged patch set 7 07/29/25, 11:49