Review main Abandoned

89654[BUGFIX] Respect hidden state of sys_template records for TypoScript

Stefan Froemken CR 0 V 0 Easy +4 −1 updated 06/06/25, 13:19

Commit message

This change ensures that only visible (not hidden) `sys_template`
records are used when constructing the valid TypoScript for a page
in `BackendConfigurationManager`.

The method `getSysTemplateRowsByRootline` could not be changed directly,
as respecting hidden `sys_template` records remains required for the
TypoScript backend module to display all records. However, for
generating the effective TypoScript for a page, only those records that
are not marked as hidden are now included.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Stefan Froemken uploaded patch set 1 06/06/25, 06:49

  2. Stefan Froemken commented on patch set 1 06/06/25, 06:51

    Hi reviewers. Currently, I only respect main branch. Please leave a note, if I should add 13.4, too. Thank you.
  3. core-ci voted on patch set 1 V +1 06/06/25, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79968

  4. Oliver Klee updated the commit message in patch set 2 V +1 06/06/25, 08:53

  5. core-ci voted on patch set 2 V +1 06/06/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79976

  6. Stefan Bürk commented on patch set 2 06/06/25, 09:53

    Unresolved

    I'd postulate that this change is not needed and that this is not a bug. VisibilityContext for BACKEND is initalized to include (use) hidden records and the called `SysTemplateRepository->getSysTemplateRowsByRootline()` respects the VisibilityAspect settings of the context. With that background, code using the `BackendConfigurationManager` directly should set the VisibilityAspect to the needs they want and restore it afterwards. See also the other settings like respicting start/end etc.
  7. Stefan Froemken abandoned the change 06/06/25, 13:19

    Prevent hidden records via Context API before accessing the TypoScript in BE.