89655[TASK] Update to CKEditor 45.2.1
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 129
- Build/overrides/ckeditor5/package.json+1 −1
- Build/rollup/ckeditor.js1+1 −0
- Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-link.js+0 −1
- Build/Sources/Sass/element/typo3-rte-ckeditor-ckeditor5.scss+5 −0
- Build/Sources/TypeScript/rte-ckeditor/legacy/ckeditor5-bundle.ts+1 −1
- Build/Sources/TypeScript/rte-ckeditor/plugin/typo3-link.ts+154 −86
- Build/types/ckeditor5-bundle/index.d.ts+0 −1
- Build/package-lock.json+495 −346
- Build/package.json+39 −37
- Build/web-test-runner.config.mjs+3 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/rte_ckeditor/Configuration/JavaScriptModules.php+3 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-alignment.js+11 −11
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-autoformat.js+3 −3
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-basic-styles.js+52 −52
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-block-quote.js+8 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-clipboard.js+26 −25
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-code-block.js+19 −19
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-core.js+33 −36
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-classic.js+7 −7
Show 109 more files
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-editor-multi-root.jsnew+10 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-engine.js+231 −225
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-enter.js+6 −6
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-essentials.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-find-and-replace.js+27 −27
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-font.js+49 −49
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-heading.js+15 −15
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-highlight.js+9 −9
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-horizontal-line.js+9 −9
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-html-support.js+49 −43
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-icons.js7new+21 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-image.jsnew+175 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-indent.js+15 −15
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-language.js+5 −5
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-link.js+40 −31
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-list.js+101 −101
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-mention.js+15 −15
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paragraph.js+8 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-paste-from-office.js+38 −35
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-remove-format.js+10 −10
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-select-all.js+10 −10
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-show-blocks.js+8 −8
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-source-editing.js+3 −11
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-special-characters.js+17 −17
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-style.js+25 −25
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-table.js+174 −162
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-typing.js+29 −29
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-ui.js+215 −212
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-undo.js+13 −13
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-upload.js+9 −9
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-utils.js+195 −181
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-watchdog.js+12 −12
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-widget.js+24 −24
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/@ckeditor/ckeditor5-word-count.js+7 −7
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/af.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ar.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ast.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/az.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/be.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bg.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bs.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ca.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/cs.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/da.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/de-ch.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/de.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/el.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en-au.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en-gb.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/eo.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/es-co.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/es.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/et.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/eu.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fa.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fi.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/gl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/gu.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/he.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hi.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hu.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hy.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/id.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/it.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ja.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/jv.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/kk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/km.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/kn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ko.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ku.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/lt.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/lv.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ms.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/nb.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ne.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/nl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/no.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/oc.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pt-br.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pt.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ro.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ru.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/si.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sl.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sq.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sr-latn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sv.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/th.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ti.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tr.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tt.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ug.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/uk.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ur.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/uz.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/vi.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/zh-cn.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/zh.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/legacy/ckeditor5-bundle.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/typo3-link.js+1 −1
Review log 3145
Show 1220 earlier messages
-
Garvin Hicking uploaded patch set 1 06/06/25, 07:01
-
core-ci voted on patch set 1 V -1 06/06/25, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79969
-
Benjamin Franzke uploaded patch set 2
V -106/11/25, 07:47 -
core-ci voted on patch set 2 V -1 06/11/25, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80177
-
Garvin Hicking uploaded patch set 3
V -106/24/25, 09:42 -
core-ci voted on patch set 3 V -1 06/24/25, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80715
-
Andreas Kienast uploaded patch set 4
V -106/24/25, 14:20 -
core-ci voted on patch set 4 V -1 06/24/25, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80740
-
Andreas Kienast uploaded patch set 5
V -106/24/25, 14:39 -
Andreas Kienast uploaded patch set 6 06/24/25, 14:48
-
Andreas Kienast commented on patch set 6 CR -1 06/24/25, 14:48
There's still another issue regarding "fake selections", they are not removed when the link browser is closed without setting a link. -
Andreas Kienast uploaded patch set 7
CR -106/24/25, 14:52 -
Andreas Kienast commented on patch set 7 CR -1 06/24/25, 14:52
"Fake selection" issue still present -
core-ci voted on patch set 5 V -1 06/24/25, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80748
-
core-ci voted on patch set 7 V +1 06/24/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80756
-
core-ci voted on patch set 6 V -1 06/24/25, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80753
-
Garvin Hicking uploaded patch set 8
CR -1V +106/24/25, 18:22 -
core-ci voted on patch set 8 V -1 06/24/25, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80788
-
Andreas Kienast uploaded patch set 9
V -106/25/25, 07:17 -
Andreas Kienast uploaded patch set 10 06/25/25, 07:18
-
core-ci voted on patch set 9 V +1 06/25/25, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80821
-
core-ci voted on patch set 10 V +1 06/25/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80822
-
Garvin Hicking updated the commit message in patch set 11
V +106/25/25, 07:33 -
core-ci voted on patch set 11 V +1 06/25/25, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80824
-
Andreas Nedbal voted on patch set 11 CR +1 V +1 06/25/25, 16:30
-
Benjamin Franzke commented on patch set 11 CR -1 06/25/25, 17:58
ckeditor5-icons.js:1The new modules need to be registered in JavaScriptModules.php in order to be loadable. -
Benjamin Franzke commented on patch set 11 06/25/25, 18:03
ckeditor5-icons.js:1Reply(also in Build/web-test-runner.config.mjs – for sake of completeness) -
Garvin Hicking uploaded patch set 12
CR +1V +106/25/25, 19:52 -
Garvin Hicking commented on patch set 12 CR +1 V +1 06/25/25, 19:56
works on my machineckeditor5-icons.js:1ReplyJavaScriptModules.php did contain ckeditor5-icons already. The other modules haven't been enabled yet (emoji+fullscreen) as they will need a seperate patch. I've added ckeditor5-icons to web-test-runner.conf.mjs and added a note in the followup issues for this. OK? -
core-ci voted on patch set 12 V +1 06/25/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80908
-
Andreas Kienast commented on patch set 12 CR -2 06/26/25, 06:56
Blocking for until @ben@bnf.dev checked the patch as well.ckeditor5-icons.js:1ReplyThere are a few more modules added through indirect dependencies, which needs mapping as well. -
Garvin Hicking commented on patch set 12 CR 0 V 0 06/26/25, 08:18
ckeditor5-icons.js:1ReplyHow can I reveal this to adjust the patch, or are you on it? -
Garvin Hicking commented on patch set 12 06/26/25, 09:05
ckeditor5-icons.js:1ReplyUnderstood, these two modules need(ed) inspection: @ckeditor/ckeditor5-editor-multi-root @ckeditor/ckeditor5-image "editor-multi-root" provides the "AddRootEvent" and is a dependency of "ckeditor5-ui" now. If I read that right it is mostly related to the realtime-collab premium plugin, and I am not aware of usage scnearios of https://ckeditor.com/docs/ckeditor5/latest/examples/builds/multi-root-editor.html within our core implementations, since we only use ClassicEditor instances. "image" is a dependency of "ckeditor5-link" now. Of course this is a huge lib that we actively wanted to prevent being part of the core implementation as to my understanding. How would we deal with both, I suppose if we already "need" to bundle them due to their internal CKEditor dependencies, we could as well expose this in JavaScriptModules.php to make 3rd party implementations possible, right? -
Benjamin Franzke uploaded patch set 13
V +106/26/25, 14:45Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke commented on patch set 13 06/26/25, 14:46
ckeditor.js:78Has no impact on file size, removed.ckeditor5-icons.js:1ReplyI inspect newly added files and add them to those mappings via vim-foo ;) `'<,'>s/.*/ '&' => 'EXT:rte_ckeditor\/Resources\/Public\/Contrib\/&.js',/` Anyway, done -
core-ci voted on patch set 13 V +1 06/26/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80991
-
Benjamin Franzke uploaded patch set 14
V +107/02/25, 13:28Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke commented on patch set 14 07/02/25, 13:28
12.4 releases are becoming rare, let's avoid the backport, since we'll have hard times having to backport possible upstream regressions into v12. There is no urgent need in v12 for this ckeditor release atm and therefore we should let it rest as is.. -
core-ci voted on patch set 14 V +1 07/02/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81245
-
Garvin Hicking commented on patch set 14 07/02/25, 15:05
Reply
I agree with this; there are some features that have a nice pull to maybe inspire people to upgrade to v13. ;) -
Andreas Kienast voted on patch set 14 CR 0 07/04/25, 07:14
-
Garvin Hicking commented on patch set 14 CR +1 V +1 07/04/25, 07:21
(Voting on this as Andi did the heavy lifting) -
Andreas Kienast voted on patch set 14 CR +2 V +2 07/04/25, 07:47
-
Andreas Kienast merged patch set 15 07/04/25, 08:02