Review main Merged

89655[TASK] Update to CKEditor 45.2.1

Garvin Hicking CR +2 V +2 Nightmare +2512 −2032 updated 07/04/25, 08:02

Commit message

The ckeditor bundle is updated to version 45.2.1. Due to breaking
changes [1], our own link UI needs some refactoring.

Commands:

  cd Build
  # lodash dependency was removed, load explicitly
  # (for now, we could drop it, but extensions may use it as a dep)
  npm install --save lodash-es@^4.17
  npm --prefix overrides/ckeditor5 version 45.2.1
  npm install --save ./overrides/ckeditor5 $(
    grep @ckeditor/ package.json | \
    grep -v @ckeditor/ckeditor5-dev-utils | \
    grep -v @ckeditor/ckeditor5-inspector | \
    sed 's/^[^"]*"\([^"]*\)".*/\1@45.2.1/' \
  )
  npm install --save @ckeditor/ckeditor5-icons@^45.2.1
  npm run build

The new plugins "Emoji" and "Fullscreen" need more work, seperate
issues [2] [3] have been created for this as a follow-up.

[1] https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-45.html#ui-toolbar-refactoring
[2] https://forge.typo3.org/issues/106961
[3] https://forge.typo3.org/issues/106962

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 129

Show 109 more files

Review log 3145

Show 1220 earlier messages
  1. Garvin Hicking uploaded patch set 1 06/06/25, 07:01

  2. core-ci voted on patch set 1 V -1 06/06/25, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79969

  3. Benjamin Franzke uploaded patch set 2 V -1 06/11/25, 07:47

  4. core-ci voted on patch set 2 V -1 06/11/25, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80177

  5. Garvin Hicking uploaded patch set 3 V -1 06/24/25, 09:42

  6. core-ci voted on patch set 3 V -1 06/24/25, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80715

  7. Andreas Kienast uploaded patch set 4 V -1 06/24/25, 14:20

  8. core-ci voted on patch set 4 V -1 06/24/25, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80740

  9. Andreas Kienast uploaded patch set 5 V -1 06/24/25, 14:39

  10. Andreas Kienast uploaded patch set 6 06/24/25, 14:48

  11. Andreas Kienast commented on patch set 6 CR -1 06/24/25, 14:48

    There's still another issue regarding "fake selections", they are not removed when the link browser is closed without setting a link.
  12. Andreas Kienast uploaded patch set 7 CR -1 06/24/25, 14:52

  13. Andreas Kienast commented on patch set 7 CR -1 06/24/25, 14:52

    "Fake selection" issue still present
  14. core-ci voted on patch set 5 V -1 06/24/25, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80748

  15. core-ci voted on patch set 7 V +1 06/24/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80756

  16. core-ci voted on patch set 6 V -1 06/24/25, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80753

  17. Garvin Hicking uploaded patch set 8 CR -1 V +1 06/24/25, 18:22

  18. core-ci voted on patch set 8 V -1 06/24/25, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80788

  19. Andreas Kienast uploaded patch set 9 V -1 06/25/25, 07:17

  20. Andreas Kienast uploaded patch set 10 06/25/25, 07:18

  1. core-ci voted on patch set 9 V +1 06/25/25, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80821

  2. core-ci voted on patch set 10 V +1 06/25/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80822

  3. Garvin Hicking updated the commit message in patch set 11 V +1 06/25/25, 07:33

  4. core-ci voted on patch set 11 V +1 06/25/25, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80824

  5. Andreas Kienast commented on patch set 11 06/25/25, 07:42

    Reply

    Done

    Reply

    Done
  6. Andreas Nedbal voted on patch set 11 CR +1 V +1 06/25/25, 16:30

  7. Benjamin Franzke commented on patch set 11 CR -1 06/25/25, 17:58

    ckeditor5-icons.js:1

    The new modules need to be registered in JavaScriptModules.php in order to be loadable.
  8. Benjamin Franzke commented on patch set 11 06/25/25, 18:03

    ckeditor5-icons.js:1 Reply

    (also in Build/web-test-runner.config.mjs – for sake of completeness)
  9. Garvin Hicking uploaded patch set 12 CR +1 V +1 06/25/25, 19:52

  10. Garvin Hicking commented on patch set 12 CR +1 V +1 06/25/25, 19:56

    works on my machine

    ckeditor5-icons.js:1 Reply

    JavaScriptModules.php did contain ckeditor5-icons already. The other modules haven't been enabled yet (emoji+fullscreen) as they will need a seperate patch. I've added ckeditor5-icons to web-test-runner.conf.mjs and added a note in the followup issues for this. OK?
  11. core-ci voted on patch set 12 V +1 06/25/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80908

  12. Andreas Kienast commented on patch set 12 CR -2 06/26/25, 06:56

    Blocking for until @ben@bnf.dev checked the patch as well.

    ckeditor5-icons.js:1 Reply

    There are a few more modules added through indirect dependencies, which needs mapping as well.
  13. Garvin Hicking commented on patch set 12 CR 0 V 0 06/26/25, 08:18

    ckeditor5-icons.js:1 Reply

    How can I reveal this to adjust the patch, or are you on it?
  14. Garvin Hicking commented on patch set 12 06/26/25, 09:05

    ckeditor5-icons.js:1 Reply

    Understood, these two modules need(ed) inspection: @ckeditor/ckeditor5-editor-multi-root @ckeditor/ckeditor5-image "editor-multi-root" provides the "AddRootEvent" and is a dependency of "ckeditor5-ui" now. If I read that right it is mostly related to the realtime-collab premium plugin, and I am not aware of usage scnearios of https://ckeditor.com/docs/ckeditor5/latest/examples/builds/multi-root-editor.html within our core implementations, since we only use ClassicEditor instances. "image" is a dependency of "ckeditor5-link" now. Of course this is a huge lib that we actively wanted to prevent being part of the core implementation as to my understanding. How would we deal with both, I suppose if we already "need" to bundle them due to their internal CKEditor dependencies, we could as well expose this in JavaScriptModules.php to make 3rd party implementations possible, right?
  15. Benjamin Franzke uploaded patch set 13 V +1 06/26/25, 14:45

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  16. Benjamin Franzke commented on patch set 13 06/26/25, 14:46

    ckeditor.js:78

    Has no impact on file size, removed.

    ckeditor5-icons.js:1 Reply

    I inspect newly added files and add them to those mappings via vim-foo ;) `'<,'>s/.*/ '&' => 'EXT:rte_ckeditor\/Resources\/Public\/Contrib\/&.js',/` Anyway, done
  17. core-ci voted on patch set 13 V +1 06/26/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80991

  18. Benjamin Franzke uploaded patch set 14 V +1 07/02/25, 13:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  19. Benjamin Franzke commented on patch set 14 07/02/25, 13:28

    12.4 releases are becoming rare, let's avoid the backport, since we'll have hard times having to backport possible upstream regressions into v12. There is no urgent need in v12 for this ckeditor release atm and therefore we should let it rest as is..
  20. core-ci voted on patch set 14 V +1 07/02/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81245

  21. Garvin Hicking commented on patch set 14 07/02/25, 15:05

    Reply

    I agree with this; there are some features that have a nice pull to maybe inspire people to upgrade to v13. ;)
  22. Andreas Kienast voted on patch set 14 CR 0 07/04/25, 07:14

  23. Garvin Hicking commented on patch set 14 CR +1 V +1 07/04/25, 07:21

    (Voting on this as Andi did the heavy lifting)
  24. Andreas Kienast voted on patch set 14 CR +2 V +2 07/04/25, 07:47

  25. Andreas Kienast merged patch set 15 07/04/25, 08:02