89659[FEATURE] Introduce shell auto-completion for the `typo3` script
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1722
-
Stefan Bürk uploaded patch set 1 06/06/25, 09:06
-
Stefan Bürk updated the commit message in patch set 2 06/06/25, 09:08
-
core-ci voted on patch set 1 V -1 06/06/25, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79977
-
core-ci voted on patch set 2 V -1 06/06/25, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79978
-
Stefan Bürk uploaded patch set 3
V -106/06/25, 09:19 -
core-ci voted on patch set 3 V +1 06/06/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79979
-
Garvin Hicking commented on patch set 4
V +106/07/25, 08:39Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 CR +1 V +1 06/07/25, 08:44
Works for me, however in ddev I have to manually specify that "bash" is my shell, even tough $SHELL="/bin/bash". But I think that's not issue of this patch. Nifty improvement, thanks for getting on it. I could probably even take this as a TASK and put it in v13 :-P -
core-ci voted on patch set 4 V +1 06/07/25, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80047
-
Stefan Bürk commented on patch set 4 06/08/25, 11:06
Reply
I would not break the policy here. This is clearly a "feature" - albeit a rough basic one. Tha power would be revealed once argument handling for commands are enrichched, kind of related how it has been done as a community effort for symfony itself: https://github.com/symfony/symfony/issues/43594 Beside that, once having it installied with a main/v14 into the shell it would at least tha generic tab for command compleation. Secondly, it's pretty easy to make a v12/v13 extension to register that command from the outside if wanted in projects for custom commands. -
Simon Schaufelberger commented on patch set 4 06/16/25, 12:09
Feature-106839-IntroduceShellAuto-completionForTheTypo3Script.rst:83does this mean the arguments are only used from this one project and not for multiple different projects? I think the documentation should make it clear how to use the command for multiple projects being used on the same system. -
Stefan Bürk commented on patch set 4 06/17/25, 15:26
Feature-106839-IntroduceShellAuto-completionForTheTypo3Script.rst:83ReplyI'd say that is enough for the changelog. If required can be done within the documentation in the general we document every command think. And it's also the default symfony command description. -
Garvin Hicking commented on patch set 4 06/17/25, 15:52
Feature-106839-IntroduceShellAuto-completionForTheTypo3Script.rst:83ReplyI think, normally you would alter the shell inside the container with that auto completion, then it's project specific. Doing it on the host only works well if you have dedicated project workspaces or shells, but for people having this scenario they can deal on their own I would argue? Documenting shell scenarios might not need to be part of the TYPO3 changelog, since its not really our "feature"? I'd be in favor to get this in as-is, would that be fine with you? -
Simon Schaufelberger commented on patch set 4 06/17/25, 15:57
Feature-106839-IntroduceShellAuto-completionForTheTypo3Script.rst:83ReplyI'm ok with it, I just wanted to clarify this because it specifically mentions "core" and having the line in "~/.bashrc" would be a global setting which can confuse people. -
Garvin Hicking commented on patch set 5
CR +1V +106/17/25, 16:06Published edit on patch set 4. -
Garvin Hicking voted on patch set 5 CR +1 V +1 06/17/25, 16:06
-
Garvin Hicking commented on patch set 5 06/17/25, 16:07
Feature-106839-IntroduceShellAuto-completionForTheTypo3Script.rst:83ReplyI see your point. I added one sentence, is this an acceptable middleground for everyone? :-) -
Simon Schaufelberger commented on patch set 5 06/17/25, 16:09
Feature-106839-IntroduceShellAuto-completionForTheTypo3Script.rst:83ReplyAcknowledged -
Simon Schaufelberger voted on patch set 5 CR +1 V +1 06/17/25, 16:09
-
core-ci voted on patch set 5 V +1 06/17/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80432
-
Stefan Bürk voted on patch set 5 CR +2 V +2 06/17/25, 16:18
-
Stefan Bürk merged patch set 6 06/17/25, 16:18