89660[BUGFIX] Prevent attaching non-object values in ObjectStorageConverter
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectStorageConverter.php2+3 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/type_converter_test/Classes/Domain/Model/Home.phpnew+85 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/type_converter_test/Classes/Domain/Model/Horse.phpnew+38 −0
- typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectStorageConverterTest.php+99 −4
Review log 1524
-
Stefan Froemken uploaded patch set 1 06/06/25, 10:23
-
core-ci voted on patch set 1 V -1 06/06/25, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79981
-
Stefan Froemken uploaded patch set 2
V -106/06/25, 10:45 -
Mathias Brodala commented on patch set 1 CR -1 06/06/25, 10:49
-
core-ci voted on patch set 2 V +1 06/06/25, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79982
-
Stefan Froemken uploaded patch set 3
V +106/06/25, 11:31 -
Stefan Froemken commented on patch set 3 06/06/25, 11:34
ObjectStorageConverter.php:44ReplyIt's not solvable within ObjectStorage. Since TYPO3 13 attach() expects $object to be of type "object". null is not allowed as argument. But I have changed code to use "continue" -
Stefan Froemken updated the commit message in patch set 4 06/06/25, 11:37
-
core-ci voted on patch set 3 V +1 06/06/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79985
-
Benni Mack updated the commit message in patch set 5 04/22/26, 06:34
-
core-ci voted on patch set 5 V -1 04/22/26, 07:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100736
-
core-ci commented on patch set 5 05/03/26, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100736
-
core-ci commented on patch set 5 05/03/26, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100736
-
core-ci commented on patch set 5 05/03/26, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100736
-
Oliver Klee updated the commit message in patch set 6
V -105/03/26, 08:40 -
core-ci voted on patch set 6 V -1 05/03/26, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101431
-
Oliver Klee commented on patch set 6 05/04/26, 06:38
Needs a rebase to at least update `runTests.sh` and get the CI build running again. -
Georg Ringer rebased onto patch set 7
V -109/02/26, 13:42 -
core-ci voted on patch set 7 V +1 09/02/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107636
-
Georg Ringer voted on patch set 7 CR +1 V +1 09/02/26, 13:53
-
Oliver Klee voted on patch set 7 CR +1 V +1 09/02/26, 13:57
-
Georg Ringer voted on patch set 7 CR +2 V +2 09/02/26, 14:21
-
Benni Mack voted on patch set 7 CR +1 V +1 09/02/26, 14:22
-
Georg Ringer merged patch set 8 09/02/26, 14:31
ObjectStorageConverter.php:44