Review main Merged

89662[BUGFIX] Fix DateRangeValidator changing options array

Uwe Wiebach CR +2 V +2 Easy +9 −7 updated 07/07/25, 20:42

Commit message

This fixes the validateOptions function of the DateRangeValidator
changing the minimum and maximum values within the options array to
their DateTime values, which can lead to errors with third party
extensions.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Uwe Wiebach uploaded patch set 1 06/06/25, 11:34

  2. core-ci voted on patch set 1 V +1 06/06/25, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79987

  3. Georg Ringer voted on patch set 1 CR +1 V +1 06/07/25, 05:35

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 06/18/25, 07:16

    Good catch... validateOptions() doing write operations on this does not look sane to me at all, but I guess this fix will do the trick without breakage.
  5. Uwe Wiebach rebased onto patch set 2 CR +1 V +1 06/25/25, 11:07

  6. core-ci voted on patch set 2 V +1 06/25/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80845

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 06/25/25, 21:05

    Sadly the rebase reset the votes just when I wanted to merge it -.- Lets go again 😄
  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/07/25, 14:26

  9. Georg Ringer voted on patch set 2 CR +1 V +1 07/07/25, 18:05

  10. Garvin Hicking voted on patch set 2 CR +2 V +2 07/07/25, 18:32

  11. Oliver Hader voted on patch set 2 CR +1 07/07/25, 20:06

  12. Oliver Hader voted on patch set 2 V +1 07/07/25, 20:12

  13. Garvin Hicking merged patch set 3 07/07/25, 20:42