Review main Abandoned

89664[BUGFIX] Remove transient property handling from Extbase ClassSchema

Stefan Froemken CR 0 V 0 Normal +118 −15 updated 10/02/26, 13:28

Commit message

Transient properties must not be part of ClassSchema and are ignored by
the framework. They are not persisted, not mapped, and must not trigger
TCA checks or be processed by DataMapper. Querying isTransient for such
"invisible" properties is meaningless, as those properties act as if not
declared.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 9

Review log 911

  1. Stefan Froemken uploaded patch set 1 06/06/25, 15:10

  2. core-ci voted on patch set 1 V -1 06/06/25, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79997

  3. Stefan Froemken uploaded patch set 2 V -1 06/06/25, 15:22

  4. core-ci voted on patch set 2 V +1 06/06/25, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79998

  5. Oliver Klee commented on patch set 2 06/06/25, 17:57

    ClassSchema.php:132 Unresolved

    Please let's have native parameter and return type declarations to the array function. Also, please let's avoid abbreviations: attr -> attribute
  6. Georg Ringer commented on patch set 2 06/07/25, 06:02

    can we backport that without the deprecation? or make a prepatch to just ignore the transient and deprecate it in 14 only?

    Deprecation-98224-RemoveIsTransientOfClassSchema.rst:6 Unresolved

    deprecate?
  7. Oliver Klee commented on patch set 2 06/07/25, 11:26

    ClassSchema.php:131 Unresolved

    I find this combined condition really hard to grok (i.e., to understand its purpose). Maybe we can introduce a well-named private method to make this quicker to understand?
  8. Torben Hansen commented on patch set 2 11/13/25, 09:41

    The `Transient()` feature of extbase does not seem to have any working functionality. Has anyone valid and working use cases for the feature? If not, I suggest to remove it completely.
  9. Markus Klein commented on patch set 2 02/02/26, 18:29

    Reply

    It does have a valid functionality. To ignore members of a Model class that are runtime only. a recent fix https://review.typo3.org/c/Packages/TYPO3.CMS/+/92502 already went into the right direction.
  10. Garvin Hicking abandoned the change 10/02/26, 10:25

    abandoning due to markus' comment, let me know if I misunderstood anything
  11. Alexander Schnitzler commented on patch set 2 10/02/26, 13:28

    Reply

    It is only used to skip validation at the moment and before that change, it did not have any functionality any more. It does not do what it states to do: Make a property transient, i.e. non persistable. If something is persisted is only determined by the presence of absence of a TCA configuration.