Review main Merged

89667[TASK] Add SchemaTypeInformation in favor of getSubSchemaDivisorField

Oli Bartsch CR +2 V +2 Hard +304 −0 updated 06/10/25, 10:40

Commit message

Schema API has a drawback with the existing
getSubSchemaDivisorField() as it does not cover
"uid_local:type" field from sys_file_reference.

This is now solved by introducing the information
in a DTO "SchemaTypeInformation" which will be added
to v13 as well, and supersed getSubSchemaDivisorField()
in v14 with a followup patch.

This way, Schema API gets more powerful in a few places
in TYPO3 Core, where this special handling of a remote
field value wasn't supported yet.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1117

  1. Oli Bartsch uploaded patch set 1 06/06/25, 21:16

  2. Oli Bartsch updated the commit message in patch set 2 06/06/25, 21:16

  3. core-ci voted on patch set 1 V +1 06/06/25, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80019

  4. core-ci voted on patch set 2 V +1 06/06/25, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80020

  5. Benni Mack uploaded patch set 3 V +1 06/06/25, 22:59

  6. Benni Mack uploaded patch set 4 06/06/25, 23:03

  7. core-ci voted on patch set 3 V +1 06/06/25, 23:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80031

  8. core-ci voted on patch set 4 V -1 06/06/25, 23:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80032

  9. Benni Mack uploaded patch set 5 V -1 06/09/25, 10:35

  10. Benni Mack uploaded patch set 6 06/09/25, 10:39

  11. core-ci voted on patch set 5 V +1 06/09/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80077

  12. core-ci voted on patch set 6 V +1 06/09/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80078

  13. Benni Mack voted on patch set 6 CR +1 V +1 06/09/25, 10:51

  14. Georg Ringer voted on patch set 6 CR +1 V +1 06/10/25, 07:42

  15. Oli Bartsch voted on patch set 6 CR +2 V +2 06/10/25, 08:06

  16. Oli Bartsch merged patch set 7 06/10/25, 08:06

  17. Oliver Hader commented on patch set 7 06/10/25, 10:40

    SchemaTypeInformation.php:32 Unresolved

    Shouldn't this have been a `readonly` class?