89671[!!!][TASK] Properly initialize properties in AbstractCompositeValidator
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-106847-ProperlyInitializePropertiesInAbstractCompositeValidator.rstnew+41 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php6+8 −10
- typo3/sysext/extbase/Classes/Validation/Validator/ConjunctionValidator.php+0 −6
- typo3/sysext/extbase/Classes/Validation/Validator/DisjunctionValidator.php+0 −6
Review log 1621
-
Torben Hansen uploaded patch set 1 06/08/25, 11:24
-
core-ci voted on patch set 1 V -1 06/08/25, 11:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80063
-
Torben Hansen uploaded patch set 2
V -106/08/25, 11:33 -
core-ci voted on patch set 2 V +1 06/08/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80064
-
Garvin Hicking updated the commit message in patch set 3
V +106/08/25, 16:24 -
core-ci voted on patch set 3 V +1 06/08/25, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80065
-
Oliver Klee voted on patch set 3 CR +1 06/09/25, 08:27
-
Stefan Bürk commented on patch set 3 06/10/25, 08:12
-
Torben Hansen uploaded patch set 4
CR +1V +106/11/25, 17:00 -
Torben Hansen commented on patch set 4 06/11/25, 17:01
AbstractCompositeValidator.php:45ReplyThanks, good suggestion 👍 -
core-ci voted on patch set 4 V +1 06/11/25, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80215
-
Oliver Klee voted on patch set 4 CR +1 06/11/25, 17:13
-
Christian Kuhn commented on patch set 4 06/13/25, 14:26
AbstractCompositeValidator.php:43mmmh. this violates the principle that abstracts shouldn't pollute __construct(). -
Torben Hansen uploaded patch set 5
CR +1V +106/14/25, 11:25 -
Torben Hansen commented on patch set 5 06/14/25, 11:26
AbstractCompositeValidator.php:43ReplyAlright, I changed it then back to the previous state and avoid the constructor arguments. -
core-ci voted on patch set 5 V +1 06/14/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80322
-
Oliver Klee voted on patch set 5 CR +1 06/14/25, 18:05
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 06/15/25, 23:59
-
Christian Kuhn commented on patch set 5 06/17/25, 10:48
AbstractCompositeValidator.php:43Replywell. it means the abstract still has __construct() making it "API", no matter if there are arguments or not (implementing services need to call parent::__construct() now which breaks if the abstract decides to add a constructor argument later). imho, abstracts shouldn't do this at all. it looks to me as if this change does not really help much. the issue with the validators is deeper as we can see with the statefulness of the object: they are a mixture of a data object and service and that's what bites us. it feels to me as if we should rather think about a proper class structure that solves the root issue instead of having a breaking change to improve convenience of this broken structure: it was clear we should revamp the construct when we introduced the request in v13, where we also didn't solve the real issue. maybe it's time to solve the root cause now? -
Torben Hansen commented on patch set 5 06/17/25, 11:53
AbstractCompositeValidator.php:43ReplyYou`re right, the change does not help much except trying to "resolve" a todo which has been there for years. I'm fine, if this does not come in and will abandon the patch. I understand that the current structure is not perfect from a software design principle, but have no good idea on how to resolve the issue. I'm however open for discussions/improvements in this area, which are beneficial for users of the validators. -
Torben Hansen abandoned the change 06/17/25, 11:53
Change has no real benefit
AbstractCompositeValidator.php:45