Review main Merged

89681[BUGFIX] Ignore permissions for folder deletion recycler lookup

Garvin Hicking CR +2 V +2 Easy +12 −0 updated 06/23/25, 16:49

Commit message

With #96863 a check was introduced to recursively look for a
recycler when directories get deleted, so they can be put there
instead of just hard-deleting folders.

That check however fails in scenarios where directory mounts
are used, and iterating outside the root mount directory is
not allowed via the InsufficientFolderAccessException.

This patch disables the permission checks for finding a recycler
and moving the folder to it, same as in the `deleteFile` method.

This also prevents an exception when a `_recycler_` folder is to be
deleted, and TYPO3 would use the folder itself as the move target.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Friedemann Altrock +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Friedemann Altrock +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 710

  1. Garvin Hicking uploaded patch set 1 06/10/25, 07:04

  2. core-ci voted on patch set 1 V +1 06/10/25, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80110

  3. Friedemann Altrock uploaded patch set 2 V +1 06/10/25, 11:56

  4. core-ci voted on patch set 2 V +1 06/10/25, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80143

  5. Garvin Hicking updated the commit message in patch set 3 V +1 06/10/25, 12:24

  6. Friedemann Altrock voted on patch set 3 CR +1 V +1 06/10/25, 12:30

  7. core-ci voted on patch set 3 V +1 06/10/25, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80144

  8. Benni Mack voted on patch set 3 CR +1 V +1 06/23/25, 16:29

  9. Garvin Hicking voted on patch set 3 CR +2 V +2 06/23/25, 16:30

  10. Garvin Hicking merged patch set 4 06/23/25, 16:49