Review 13.4 Merged

89682[TASK] Restrict Doctrine DBAL to minor version `4.2.*`

Stefan Bürk CR +2 V +2 Normal +31 −32 updated 06/10/25, 07:42

Commit message

Doctrine DBAL 4 forced TYPO3 to extend a couple of classes
as replacement for the dropped event system to ensure the
same functionaly and required to copy some code which is
considered internal and partly made private by Doctrine.

That requires to adopt changes in copied code over time,
and due to the consideration as internal code this happens
also within minor version like upcoming `4.3.0` [1][2][3].

To mitigate this for the TYPO3 user base the dependency is
restricted to minor version ranges to coordinate doctrine
updates with eventually required code adoptions and mitigate
breaking composer instances while keeping bugfix updates.

The TYPO3 Core Team strifes to align with the Doctrine Team
to find patterns that allow for more seamless integration in
frameworks like TYPO3 and reduce the burdon of copied code.

Used command(s):

BIN_COMPOSER="$( which composer )" \
&& ${BIN_COMPOSER} require \
  -d typo3/sysext/core --no-update --no-install \
  'doctrine/dbal':'4.2.*' \
&& ${BIN_COMPOSER} require \
  -d typo3/sysext/install --no-update --no-install \
  'doctrine/dbal':'4.2.*' \
&& ${BIN_COMPOSER} require \
  -d typo3/sysext/redirects --no-update --no-install \
  'doctrine/dbal':'4.2.*' \
&& ${BIN_COMPOSER} require -w \
  'doctrine/dbal':'4.2.*'

[1] https://github.com/doctrine/dbal/pull/6932
[2] https://github.com/doctrine/dbal/pull/6933
[3] https://github.com/doctrine/dbal/pull/6944

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Stefan Bürk uploaded patch set 1 06/10/25, 07:32

  2. core-ci voted on patch set 1 V +1 06/10/25, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80113

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 06/10/25, 07:42

  4. Stefan Bürk merged patch set 2 06/10/25, 07:42