Review 13.4 Merged

89685[TASK] Add SchemaTypeInformation in favor of getSubSchemaDivisorField

Oli Bartsch CR +2 V +2 Hard +304 −0 updated 06/10/25, 10:37

Commit message

Schema API has a drawback with the existing
getSubSchemaDivisorField() as it does not cover
"uid_local:type" field from sys_file_reference.

This is now solved by introducing the information
in a DTO "SchemaTypeInformation" which will be added
to v13 as well, and supersed getSubSchemaDivisorField()
in v14 with a followup patch.

This way, Schema API gets more powerful in a few places
in TYPO3 Core, where this special handling of a remote
field value wasn't supported yet.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 46

  1. Oli Bartsch uploaded patch set 1 06/10/25, 08:06

  2. core-ci voted on patch set 1 V -1 06/10/25, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80117

  3. Benni Mack commented on patch set 2 V -1 06/10/25, 08:42

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 06/10/25, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80118

  5. Oli Bartsch voted on patch set 2 CR +2 V +2 06/10/25, 10:37

  6. Oli Bartsch merged patch set 3 06/10/25, 10:37