89686[TASK] Revert "[TASK] Use TcaSchema in SchemaMigrator"
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Hader +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+37 −45
- typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php+2 −0
- typo3/sysext/core/Classes/ServiceProvider.php+4 −33
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+12 −19
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+4 −6
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php+3 −3
- typo3/sysext/install/Classes/ServiceProvider.php+2 −0
Review log 910
-
Benjamin Franzke uploaded patch set 1 06/10/25, 09:19
-
Benni Mack voted on patch set 1 CR +1 V +1 06/10/25, 09:20
-
Benjamin Franzke commented on patch set 1 CR -1 06/10/25, 09:24
Still checking if we can simply fix without revert. -
core-ci voted on patch set 1 V +1 06/10/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80122
-
Benjamin Franzke commented on patch set 1 06/10/25, 09:50
This is an alternative that should fix the issue directly: > 89687: [BUGFIX] Fix missing TCA-provided schemas in database upgrade wizards | https://review.typo3.org/c/Packages/TYPO3.CMS/+/89687 (reverts some service provider parts of the original patch) What do you think, should we revert and squash that fix into the original patch and remerge, or only apply the patch? -
Benjamin Franzke commented on patch set 1 CR 0 06/10/25, 10:18
Reply
Would actually like to revert first, as that makes the fix the origin patch easier to understand if it is reuploaded together with the required adaptions. -
Benni Mack commented on patch set 1 06/10/25, 13:01
Reply
please merge -
Oliver Hader voted on patch set 1 CR +1 V +1 06/10/25, 13:10
-
Benjamin Franzke voted on patch set 1 CR +2 V +2 06/10/25, 13:22
-
Benjamin Franzke merged patch set 2 06/10/25, 13:23