Review main Merged

89686[TASK] Revert "[TASK] Use TcaSchema in SchemaMigrator"

Benjamin Franzke CR +2 V +2 Normal +64 −106 updated 06/10/25, 13:23

Commit message

This reverts commit a4d79fbf97f8951bce675ff836dbbae03ed7f20f.

Reason for revert: Upgrade wizards error with "sys_filemounts
does not exist in incoming table list" and some implementation
details are to be revised.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 910

  1. Benjamin Franzke uploaded patch set 1 06/10/25, 09:19

  2. Benni Mack voted on patch set 1 CR +1 V +1 06/10/25, 09:20

  3. Benjamin Franzke commented on patch set 1 CR -1 06/10/25, 09:24

    Still checking if we can simply fix without revert.
  4. core-ci voted on patch set 1 V +1 06/10/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80122

  5. Benjamin Franzke commented on patch set 1 06/10/25, 09:50

    This is an alternative that should fix the issue directly: > 89687: [BUGFIX] Fix missing TCA-provided schemas in database upgrade wizards | https://review.typo3.org/c/Packages/TYPO3.CMS/+/89687 (reverts some service provider parts of the original patch) What do you think, should we revert and squash that fix into the original patch and remerge, or only apply the patch?
  6. Benjamin Franzke commented on patch set 1 CR 0 06/10/25, 10:18

    Reply

    Would actually like to revert first, as that makes the fix the origin patch easier to understand if it is reuploaded together with the required adaptions.
  7. Benni Mack commented on patch set 1 06/10/25, 13:01

    Reply

    please merge
  8. Oliver Hader voted on patch set 1 CR +1 V +1 06/10/25, 13:10

  9. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/10/25, 13:22

  10. Benjamin Franzke merged patch set 2 06/10/25, 13:23