Review main Merged

89689[BUGFIX] Resolve foreign table record type in Schema API

Oli Bartsch CR +2 V +2 Normal +121 −74 updated 06/10/25, 21:09

Commit message

Based on the new SubSchemaTypeInformation,
added with #106850, are now all usages
replaced to properly handle foreign table
types.

However, some parts of the system cannot
handle foreign table types, since resolving
foreign fields require a table lookup. This
is not always possible in static contexts
or when no DB access is available.

Some "@todo"'s are added to identify and
review places where resolving the foreign
table at runtime might be feasible.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 1522

  1. Oli Bartsch uploaded patch set 1 06/10/25, 10:29

  2. core-ci voted on patch set 1 V -1 06/10/25, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80128

  3. Oli Bartsch uploaded patch set 2 V -1 06/10/25, 11:02

  4. core-ci voted on patch set 2 V +1 06/10/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80133

  5. Oli Bartsch uploaded patch set 3 V +1 06/10/25, 11:12

  6. core-ci voted on patch set 3 V +1 06/10/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80135

  7. Benni Mack uploaded patch set 4 V +1 06/10/25, 12:52

  8. core-ci voted on patch set 4 V +1 06/10/25, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80146

  9. Benni Mack commented on patch set 4 06/10/25, 13:04

    UserInformationService.php:237

    I think we should switch here to the doctype registry.
  10. Oli Bartsch uploaded patch set 5 V +1 06/10/25, 13:19

  11. Oli Bartsch commented on patch set 5 06/10/25, 13:20

    UserInformationService.php:237 Reply

    Done
  12. Benni Mack commented on patch set 5 06/10/25, 13:26

    UserInformationService.php:236

    you can use DI
  13. core-ci voted on patch set 5 V -1 06/10/25, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80147

  14. Oli Bartsch uploaded patch set 6 V -1 06/10/25, 14:06

  15. core-ci voted on patch set 6 V +1 06/10/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80150

  16. Benni Mack uploaded patch set 7 V +1 06/10/25, 15:20

  17. Benni Mack commented on patch set 7 CR +1 V +1 06/10/25, 15:20

    UserInformationService.php:236 Reply

    Done
  18. Benni Mack commented on patch set 7 06/10/25, 15:20

    UserInformationService.php:236 Reply

    Done
  19. core-ci voted on patch set 7 V +1 06/10/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80154

  20. Georg Ringer voted on patch set 7 CR +1 V +1 06/10/25, 21:08

  21. Oli Bartsch voted on patch set 7 CR +2 V +2 06/10/25, 21:09

  22. Oli Bartsch merged patch set 8 06/10/25, 21:09