89697[TASK] Allow shipping upgrade wizards w/o requiring `EXT:install`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Sven Liebert +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Sven Liebert +1
- core-ci +1 CI
Issues 5
- Task #106947Allow extensions to ship update wizards without requiring EXT:install
- Task #106956Move `DatabaseUpgradeWizardsService` to `EXT:core`
- Task #106958Move `UpgradeWizardRegistry` to `EXT:core`
- Task #106963Move `PrerequisiteInterface` implementations to `EXT:core`
- Epic #106957Ensure command line based setup and upgrade wizards without optional EXT:install
Files 57
- Build/phpstan/phpstan-baseline.neon+6 −6
- Build/Scripts/phpIntegrityChecks/AnnotationChecker.php+2 −0
- typo3/sysext/core/Classes/Attribute/UpgradeWizard.phprenamed+1 −1
- typo3/sysext/core/Classes/Service/DatabaseUpgradeWizardsService.phprenamed+1 −1
- typo3/sysext/core/Classes/Upgrades/AbstractListTypeToCTypeUpdate.phprenamed+1 −1
- typo3/sysext/core/Classes/Upgrades/ChattyInterface.phprenamed+1 −1
- typo3/sysext/core/Classes/Upgrades/ConfirmableInterface.phprenamed+1 −1
- typo3/sysext/core/Classes/Upgrades/Confirmation.php3renamed+4 −1
- typo3/sysext/core/Classes/Upgrades/DatabaseUpdatedPrerequisite.phprenamed+3 −3
- typo3/sysext/core/Classes/Upgrades/PrerequisiteCollection.phprenamed+7 −2
- typo3/sysext/core/Classes/Upgrades/PrerequisiteInterface.phprenamed+1 −1
- typo3/sysext/core/Classes/Upgrades/ReferenceIndexUpdatedPrerequisite.phprenamed+4 −2
- typo3/sysext/core/Classes/Upgrades/RepeatableInterface.phprenamed+1 −1
- typo3/sysext/core/Classes/Upgrades/UpgradeWizardInterface.phprenamed+1 −1
- typo3/sysext/core/Classes/Upgrades/UpgradeWizardRegistry.phprenamed+3 −1
- typo3/sysext/core/Classes/ServiceProvider.php+6 −0
- typo3/sysext/core/Configuration/Services.php+8 −0
- typo3/sysext/core/DeprecatedClasses/ext-install/Attribute/UpgradeWizard.phpcopied+4 −8
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/AbstractListTypeToCTypeUpdate.phpnew+29 −0
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/ChattyInterface.phpcopied+4 −4
Show 37 more files
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/ConfirmableInterface.phpcopied+4 −4
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/Confirmation.phpcopied+4 −4
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/DatabaseUpdatedPrerequisite.phpnew+32 −0
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/PrerequisiteInterface.phpcopied+4 −4
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/ReferenceIndexUpdatedPrerequisite.phpnew+30 −0
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/RepeatableInterface.phpcopied+4 −4
- typo3/sysext/core/DeprecatedClasses/ext-install/Updates/UpgradeWizardInterface.phpcopied+4 −4
- typo3/sysext/core/Documentation/Changelog/13.4/Deprecation-105076-PluginContentElementAndPluginSubTypes.rst+1 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-106947-MoveUpgradeWizardRelatedInterfacesAndAttributeToEXTcore.rstnew+274 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Important-106947-AllowExtensionsToShipUpgradeWizardsWithoutRequiringEXTinstall.rstnew+61 −0
- typo3/sysext/core/composer.json+3 −0
- typo3/sysext/extensionmanager/Classes/Updates/AbstractDownloadExtensionUpdate.php+3 −3
- typo3/sysext/install/Classes/Command/UpgradeWizardListCommand.php+4 −3
- typo3/sysext/install/Classes/Command/UpgradeWizardRunCommand.php+6 −6
- typo3/sysext/install/Classes/Controller/UpgradeController.php+1 −1
- typo3/sysext/install/Classes/Service/UpgradeWizardsService.php+5 −5
- typo3/sysext/install/Classes/Updates/DatabaseRowsUpdateWizard.php+4 −1
- typo3/sysext/install/Classes/Updates/IndexedSearchCTypeMigration.php+2 −1
- typo3/sysext/install/Classes/Updates/MediaFieldsZeroToNullUpdateWizard.php+4 −1
- typo3/sysext/install/Classes/Updates/MigrateExtensionDataImportRegistryKeysUpdate.php+5 −3
- typo3/sysext/install/Classes/Updates/NullToDefaultUpdateWizard.php+4 −1
- typo3/sysext/install/Classes/Updates/PageDoktypeLinkMigration.php+4 −2
- typo3/sysext/install/Classes/Updates/PagesRecyclerDoktypeMigration.php+3 −1
- typo3/sysext/install/Classes/Updates/SynchronizeColPosAndCTypeWithDefaultLanguage.php+3 −1
- typo3/sysext/install/Classes/Updates/SysFileMimeTypeMigration.php+3 −1
- typo3/sysext/install/Classes/Updates/UserPermissionsForRenamedModulesMigration.php+3 −2
- typo3/sysext/install/Classes/ServiceProvider.php+3 −8
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+55 −0
- typo3/sysext/install/Configuration/Services.phpdeleted+0 −19
- typo3/sysext/install/Configuration/Services.yaml+0 −7
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/CustomCTypeMigration.php+2 −2
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/InvalidCustomCTypeMigrationEmptyArrayKey.php+2 −2
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/InvalidCustomCTypeMigrationEmptyArrayValue.php+2 −2
- typo3/sysext/install/Tests/Functional/Updates/UserPermissionsForRenamedModulesMigrationTest.php+0 −1
- typo3/sysext/scheduler/Classes/Migration/SchedulerDatabaseStorageMigration.php+3 −3
- typo3/sysext/sys_note/Classes/Migration/SysNoteDashboardWidgetDatabaseMigration.php+3 −3
- composer.json+4 −1
Review log 65101
Show 4876 earlier messages
-
Benjamin Franzke uploaded patch set 1 06/10/25, 14:59
-
core-ci voted on patch set 1 V +1 06/10/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80151
-
Benjamin Franzke uploaded patch set 2
V +106/10/25, 15:05 -
core-ci voted on patch set 2 V +1 06/10/25, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80152
-
Stefan Bürk uploaded patch set 3
V +106/23/25, 11:23 -
core-ci voted on patch set 3 V +1 06/23/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80601
-
Benni Mack commented on patch set 3 06/23/25, 12:11
please check with @bo@cedev.de if we want to name the new Interface "UpgradeWizardInterface" or "UpdateWizardInterface" -
Benjamin Franzke commented on patch set 3 06/23/25, 13:02
Reply
Thanks for the heads up! Given our existing CLI interface, which already uses "upgrade" I'd vote for streamlining everything to "Upgrade": ``` bin/typo3 list upgrade Available commands for the "upgrade" namespace: upgrade:run Run upgrade wizard. Without arguments all available wizards will be run. upgrade:list List available upgrade wizards. upgrade:mark:undone Mark upgrade wizard as undone. ``` That means the core namespace would be "Upgrades\" instead of "Updates\". Also it makes it easier from "TYPO3 Update" (the processing of changing dependencies/source) and the post-step migration (which we call "upgrade"). -
Benjamin Franzke commented on patch set 3 06/23/25, 13:07
./typo3/sysext/install/Classes/Attribute/UpgradeWizard.php is missing as well -
Stefan Bürk commented on patch set 3 06/23/25, 19:57
Reply
Would opt for normalizing towards "upgrade",too. Can we get a consense here in some way ? @bo@cedev.de @benni@typo3.org -
Benni Mack commented on patch set 3 06/23/25, 20:59
Reply
fine by me, as long as we document the naming in an important RST for future references. -
Oli Bartsch commented on patch set 3 06/24/25, 08:56
Reply
I actually though we would streamline everything towards "updates". But I'll be fine with "upgrades" as long as we follow this through the core now. -
Stefan Bürk uploaded patch set 4
V +106/24/25, 09:03 -
core-ci voted on patch set 4 V +1 06/24/25, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80705
-
Stefan Bürk uploaded patch set 5
V +106/24/25, 13:28 -
core-ci voted on patch set 5 V +1 06/24/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80728
-
Markus Klein updated the commit message in patch set 6
V +106/24/25, 13:46 -
core-ci voted on patch set 6 V +1 06/24/25, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80731
-
Christian Kuhn commented on patch set 6 06/24/25, 14:01
*like*. i agree we need the main structure within ext:core making ext:install the ui on-top, only.Confirmation.php:20class could be set readonly (at least when non-readonly inheritances b/w layers are gone, i guess?). should we add a todo about this?ChattyInterface.php:23do we remove this in v14 already with a post-merge main-only change? if kept in v14, we should adapt the comments? -
Garvin Hicking uploaded patch set 7
V +106/24/25, 14:04 -
core-ci voted on patch set 7 V +1 06/24/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80736
-
Stefan Bürk commented on patch set 7 06/24/25, 14:14
ChattyInterface.php:23Replyalredy working on the post-merge main only deprecation removal for this. -
Stefan Bürk uploaded patch set 8
V +106/24/25, 14:25 -
Stefan Bürk commented on patch set 8 06/24/25, 14:27
Confirmation.php:20Replyadded todo in this change now and making it readonly in main then. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/89848ChattyInterface.php:23Reply -
Stefan Bürk commented on patch set 8 06/24/25, 14:27
Reply
Done -
Stefan Bürk uploaded patch set 9 06/24/25, 14:40
-
core-ci voted on patch set 8 V +1 06/24/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80743
-
core-ci voted on patch set 9 V +1 06/24/25, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80749
-
Stefan Bürk commented on patch set 9 06/24/25, 15:07
Reply
DoneConfirmation.php:20ReplyDoneChattyInterface.php:23ReplyDone -
Stefan Bürk uploaded patch set 10
V +106/24/25, 15:31 -
core-ci voted on patch set 10 V +1 06/24/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80763
-
Stefan Bürk uploaded patch set 11
V +106/24/25, 16:25 -
core-ci voted on patch set 11 V +1 06/24/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80774
-
Stefan Bürk updated the commit message in patch set 12
V +106/24/25, 18:15 -
Stefan Bürk commented on patch set 12 06/24/25, 18:22
I guess `\TYPO3\CMS\Install\Updates\AbstractListTypeToCTypeUpdate` needs also to be moved to EXT:core .... -
core-ci voted on patch set 12 V +1 06/24/25, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80784
-
Stefan Bürk uploaded patch set 13
V +106/24/25, 19:56 -
Stefan Bürk commented on patch set 13 06/24/25, 19:59
Reply
Done -
core-ci voted on patch set 13 V +1 06/24/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80800
-
Stefan Bürk rebased onto patch set 14
V +106/26/25, 11:14 -
core-ci voted on patch set 14 V +1 06/26/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80974
-
Benjamin Franzke uploaded patch set 15
V +106/26/25, 16:39 -
Benjamin Franzke commented on patch set 15 06/26/25, 16:39
Thanks for finishing this one @stefan@buerk.tech ❤️ -
core-ci voted on patch set 15 V +1 06/26/25, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80999
-
Stefan Bürk commented on patch set 16
V +106/26/25, 16:49Published edit on patch set 15. -
core-ci voted on patch set 16 V +1 06/26/25, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81001
-
Stefan Bürk voted on patch set 16 CR +1 V +1 06/26/25, 17:57
-
Benjamin Franzke updated the commit message in patch set 17
CR +1V +106/26/25, 18:24 -
core-ci voted on patch set 17 V +1 06/26/25, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81008
-
Stefan Bürk voted on patch set 17 CR +1 V +1 06/26/25, 19:05
-
Benjamin Franzke rebased onto patch set 18
CR +1V +106/26/25, 19:31 -
Stefan Bürk voted on patch set 18 CR +1 V +1 06/26/25, 19:31
-
core-ci voted on patch set 18 V +1 06/26/25, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81021
-
Benni Mack commented on patch set 18 06/27/25, 06:49
I don't understand the deprecation strategy based on the RSTs. - The information in the 13.4.x/Deprecation file actually should be moved into the Important RST as this is the important part. TLDR of the document is: New interfaces are added in EXT:core, EXT:install are now synonyms - both work but ext authors are encouraged to use the new interfaces. Explanation why these are added there is good and should be in the Important RST - The Deprecation RST could then just be added to v14 - incl. the @deprecated annotation. Explaining that people can use EXT:core interface since 13.4.15. Also, it should be mentioned that there is no deprecation. What I'm missing, or: what I'm trying to explain here: There is no hard problem right now for ext authors to change their upgrade wizards *now* (in v13). It's more a "If you start now, do it right." -
Benjamin Franzke commented on patch set 18 07/02/25, 13:17
Reply
My recommendation was to add the deprecation to v13 and to remove the compat-interfaces in v14 in a subsequent-breaking change that references named deprecation. That way it's "fine" to ship `@deprecated` in the v13 backport. -
Stefan Bürk uploaded patch set 19
CR +1V +110/16/25, 15:43 -
core-ci voted on patch set 19 V -1 10/16/25, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86829
-
Stefan Bürk uploaded patch set 20
V -110/16/25, 16:02 -
core-ci voted on patch set 20 V +1 10/16/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86831
-
Stefan Bürk uploaded patch set 21
V +111/12/25, 11:34 -
core-ci voted on patch set 21 V +1 11/12/25, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89290
-
Stefan Bürk uploaded patch set 22
V +111/12/25, 13:21 -
core-ci voted on patch set 22 V +1 11/12/25, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89320
-
Stefan Bürk rebased onto patch set 23
V +111/12/25, 14:19 -
core-ci voted on patch set 23 V +1 11/12/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89336
-
Stefan Bürk uploaded patch set 24
V +111/12/25, 14:44 -
core-ci voted on patch set 24 V +1 11/12/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89341
-
Stefan Bürk uploaded patch set 25
V +111/12/25, 15:37 -
Stefan Bürk rebased onto patch set 26 11/12/25, 15:39
-
core-ci voted on patch set 25 V +1 11/12/25, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89355
-
core-ci voted on patch set 26 V +1 11/12/25, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89358
-
Stefan Bürk uploaded patch set 27
V +111/13/25, 10:00 -
core-ci voted on patch set 27 V +1 11/13/25, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89454
-
Stefan Bürk uploaded patch set 28
V +111/13/25, 12:09 -
core-ci voted on patch set 28 V +1 11/13/25, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89491
-
Stefan Bürk uploaded patch set 29
V +111/13/25, 13:43
-
Stefan Bürk wrote 11/13/25, 13:50
Topic set to upgrade-wizards -
core-ci voted on patch set 29 V +1 11/13/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89508
-
Stefan Bürk rebased onto patch set 30
V +111/13/25, 14:02 -
core-ci voted on patch set 30 V +1 11/13/25, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89513
-
Stefan Bürk rebased onto patch set 31
V +111/13/25, 19:32 -
core-ci voted on patch set 31 V +1 11/13/25, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89573
-
Stefan Bürk rebased onto patch set 32
V +111/14/25, 08:26 -
core-ci voted on patch set 32 V +1 11/14/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89661
-
Stefan Bürk rebased onto patch set 33
V +111/14/25, 19:49 -
core-ci voted on patch set 33 V +1 11/14/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89717
-
Stefan Bürk uploaded patch set 34
V +111/24/25, 15:19 -
core-ci voted on patch set 34 V +1 11/24/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90856
-
Stefan Bürk rebased onto patch set 35
V +111/24/25, 15:54 -
core-ci voted on patch set 35 V +1 11/24/25, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90864
-
Stefan Bürk commented on patch set 35 11/24/25, 16:36
This change is ready for review.Reply
Changed the deprecation strategy and kept this v14 only in a non-breaking way. -
Sven Liebert voted on patch set 35 CR +1 V +1 11/24/25, 16:50
-
Garvin Hicking commented on patch set 35 CR -1 11/24/25, 18:15
on it, hang on -
Garvin Hicking uploaded patch set 36
CR +1V +111/24/25, 18:41 -
Garvin Hicking commented on patch set 36 CR +1 V +1 11/24/25, 18:42
"works on my machine" -
Sven Liebert voted on patch set 36 CR +1 V +1 11/24/25, 18:46
-
core-ci voted on patch set 36 V +1 11/24/25, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90886
-
Stefan Bürk voted on patch set 36 CR +2 V +2 11/24/25, 18:53
-
Stefan Bürk merged patch set 37 11/24/25, 18:53
-
Lina Wolf commented on patch set 37 12/01/25, 06:00