Review main Merged

89697[TASK] Allow shipping upgrade wizards w/o requiring `EXT:install`

Benjamin Franzke CR +2 V +2 Hard +637 −135 updated 12/01/25, 06:00

Commit message

With TYPO3 v13 it has been communicated that `EXT:install` is
optional, which is not the full truth in case that extensions
or projects implement own upgrade wizards, because TYPO3 does
not provide a way to list or execute upgrade wizards when the
`EXT:install` extension is not installed.

This change is the first change in a series of changes making
`EXT:install` more optional, while providing at least a way on
CLI to execute the upgrade wizards by moving required classes
and public interfaces from `EXT:install` to `EXT:core` as the
first step.

While moving to `EXT:core`, the wording of the namespace is
streamlined to use `Upgrades` in favor of `Updates` to use
consistent names in all places. This allows for easier
differentiation from the term "TYPO3 Update", which describes
the process of changing dependencies, and the term "Upgrade"
which we use for migration steps.

Public facing classes and interfaces from `EXT:install` are
now provided in `EXT:core`, with the old namespaces using
composer classmaps to allow seamless migration in case dual
TYPO3 version support needs to be provided, for example by
extensions.

It has been decided on purpose to not use the
`typo3/class-alias-loader` package here with a class alias,
to allow a working state in case the composer plugin is not
allowed or `--no-plugins` was used. This also means, we cannot
make moved interfaces and class final right away.

Internal classes are also moved along the way to allow
moving all public facing classes and interfaces, which
is considered non-breaking.

Autoconfiguration and registration based on the `UpgradeWizard`
attribute has been moved to `EXT:core`.

Used command:

  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 5

Files 57

Show 37 more files

Review log 65101

Show 4876 earlier messages
  1. Benjamin Franzke uploaded patch set 1 06/10/25, 14:59

  2. core-ci voted on patch set 1 V +1 06/10/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80151

  3. Benjamin Franzke uploaded patch set 2 V +1 06/10/25, 15:05

  4. core-ci voted on patch set 2 V +1 06/10/25, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80152

  5. Stefan Bürk uploaded patch set 3 V +1 06/23/25, 11:23

  6. core-ci voted on patch set 3 V +1 06/23/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80601

  7. Benni Mack commented on patch set 3 06/23/25, 12:11

    please check with @bo@cedev.de if we want to name the new Interface "UpgradeWizardInterface" or "UpdateWizardInterface"
  8. Benjamin Franzke commented on patch set 3 06/23/25, 13:02

    Reply

    Thanks for the heads up! Given our existing CLI interface, which already uses "upgrade" I'd vote for streamlining everything to "Upgrade": ``` bin/typo3 list upgrade Available commands for the "upgrade" namespace: upgrade:run Run upgrade wizard. Without arguments all available wizards will be run. upgrade:list List available upgrade wizards. upgrade:mark:undone Mark upgrade wizard as undone. ``` That means the core namespace would be "Upgrades\" instead of "Updates\". Also it makes it easier from "TYPO3 Update" (the processing of changing dependencies/source) and the post-step migration (which we call "upgrade").
  9. Benjamin Franzke commented on patch set 3 06/23/25, 13:07

    ./typo3/sysext/install/Classes/Attribute/UpgradeWizard.php is missing as well
  10. Stefan Bürk commented on patch set 3 06/23/25, 19:57

    Reply

    Would opt for normalizing towards "upgrade",too. Can we get a consense here in some way ? @bo@cedev.de @benni@typo3.org
  11. Benni Mack commented on patch set 3 06/23/25, 20:59

    Reply

    fine by me, as long as we document the naming in an important RST for future references.
  12. Oli Bartsch commented on patch set 3 06/24/25, 08:56

    Reply

    I actually though we would streamline everything towards "updates". But I'll be fine with "upgrades" as long as we follow this through the core now.
  13. Stefan Bürk uploaded patch set 4 V +1 06/24/25, 09:03

  14. core-ci voted on patch set 4 V +1 06/24/25, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80705

  15. Stefan Bürk uploaded patch set 5 V +1 06/24/25, 13:28

  16. core-ci voted on patch set 5 V +1 06/24/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80728

  17. Markus Klein updated the commit message in patch set 6 V +1 06/24/25, 13:46

  18. core-ci voted on patch set 6 V +1 06/24/25, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80731

  19. Christian Kuhn commented on patch set 6 06/24/25, 14:01

    *like*. i agree we need the main structure within ext:core making ext:install the ui on-top, only.

    Confirmation.php:20

    class could be set readonly (at least when non-readonly inheritances b/w layers are gone, i guess?). should we add a todo about this?

    ChattyInterface.php:23

    do we remove this in v14 already with a post-merge main-only change? if kept in v14, we should adapt the comments?
  20. Garvin Hicking uploaded patch set 7 V +1 06/24/25, 14:04

  21. core-ci voted on patch set 7 V +1 06/24/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80736

  22. Stefan Bürk commented on patch set 7 06/24/25, 14:14

    ChattyInterface.php:23 Reply

    alredy working on the post-merge main only deprecation removal for this.
  23. Stefan Bürk uploaded patch set 8 V +1 06/24/25, 14:25

  24. Stefan Bürk commented on patch set 8 06/24/25, 14:27

    Confirmation.php:20 Reply

    added todo in this change now and making it readonly in main then. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/89848
  25. Stefan Bürk commented on patch set 8 06/24/25, 14:27

    Reply

    Done
  26. Stefan Bürk uploaded patch set 9 06/24/25, 14:40

  27. core-ci voted on patch set 8 V +1 06/24/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80743

  28. core-ci voted on patch set 9 V +1 06/24/25, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80749

  29. Stefan Bürk commented on patch set 9 06/24/25, 15:07

    Reply

    Done

    Confirmation.php:20 Reply

    Done

    ChattyInterface.php:23 Reply

    Done
  30. Stefan Bürk uploaded patch set 10 V +1 06/24/25, 15:31

  31. core-ci voted on patch set 10 V +1 06/24/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80763

  32. Stefan Bürk uploaded patch set 11 V +1 06/24/25, 16:25

  33. core-ci voted on patch set 11 V +1 06/24/25, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80774

  34. Stefan Bürk updated the commit message in patch set 12 V +1 06/24/25, 18:15

  35. Stefan Bürk commented on patch set 12 06/24/25, 18:22

    I guess `\TYPO3\CMS\Install\Updates\AbstractListTypeToCTypeUpdate` needs also to be moved to EXT:core ....
  36. core-ci voted on patch set 12 V +1 06/24/25, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80784

  37. Stefan Bürk uploaded patch set 13 V +1 06/24/25, 19:56

  38. Stefan Bürk commented on patch set 13 06/24/25, 19:59

    Reply

    Done
  39. core-ci voted on patch set 13 V +1 06/24/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80800

  40. Stefan Bürk rebased onto patch set 14 V +1 06/26/25, 11:14

  41. core-ci voted on patch set 14 V +1 06/26/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80974

  42. Benjamin Franzke uploaded patch set 15 V +1 06/26/25, 16:39

  43. Benjamin Franzke commented on patch set 15 06/26/25, 16:39

    Thanks for finishing this one @stefan@buerk.tech ❤️
  44. core-ci voted on patch set 15 V +1 06/26/25, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80999

  45. Stefan Bürk commented on patch set 16 V +1 06/26/25, 16:49

    Published edit on patch set 15.
  46. core-ci voted on patch set 16 V +1 06/26/25, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81001

  47. Stefan Bürk voted on patch set 16 CR +1 V +1 06/26/25, 17:57

  48. Benjamin Franzke updated the commit message in patch set 17 CR +1 V +1 06/26/25, 18:24

  49. core-ci voted on patch set 17 V +1 06/26/25, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81008

  50. Stefan Bürk voted on patch set 17 CR +1 V +1 06/26/25, 19:05

  51. Benjamin Franzke rebased onto patch set 18 CR +1 V +1 06/26/25, 19:31

  52. Stefan Bürk voted on patch set 18 CR +1 V +1 06/26/25, 19:31

  53. core-ci voted on patch set 18 V +1 06/26/25, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81021

  54. Benni Mack commented on patch set 18 06/27/25, 06:49

    I don't understand the deprecation strategy based on the RSTs. - The information in the 13.4.x/Deprecation file actually should be moved into the Important RST as this is the important part. TLDR of the document is: New interfaces are added in EXT:core, EXT:install are now synonyms - both work but ext authors are encouraged to use the new interfaces. Explanation why these are added there is good and should be in the Important RST - The Deprecation RST could then just be added to v14 - incl. the @deprecated annotation. Explaining that people can use EXT:core interface since 13.4.15. Also, it should be mentioned that there is no deprecation. What I'm missing, or: what I'm trying to explain here: There is no hard problem right now for ext authors to change their upgrade wizards *now* (in v13). It's more a "If you start now, do it right."
  55. Benjamin Franzke commented on patch set 18 07/02/25, 13:17

    Reply

    My recommendation was to add the deprecation to v13 and to remove the compat-interfaces in v14 in a subsequent-breaking change that references named deprecation. That way it's "fine" to ship `@deprecated` in the v13 backport.
  56. Stefan Bürk uploaded patch set 19 CR +1 V +1 10/16/25, 15:43

  57. core-ci voted on patch set 19 V -1 10/16/25, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86829

  58. Stefan Bürk uploaded patch set 20 V -1 10/16/25, 16:02

  59. core-ci voted on patch set 20 V +1 10/16/25, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86831

  60. Stefan Bürk uploaded patch set 21 V +1 11/12/25, 11:34

  61. core-ci voted on patch set 21 V +1 11/12/25, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89290

  62. Stefan Bürk uploaded patch set 22 V +1 11/12/25, 13:21

  63. core-ci voted on patch set 22 V +1 11/12/25, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89320

  64. Stefan Bürk rebased onto patch set 23 V +1 11/12/25, 14:19

  65. core-ci voted on patch set 23 V +1 11/12/25, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89336

  66. Stefan Bürk uploaded patch set 24 V +1 11/12/25, 14:44

  67. core-ci voted on patch set 24 V +1 11/12/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89341

  68. Stefan Bürk uploaded patch set 25 V +1 11/12/25, 15:37

  69. Stefan Bürk rebased onto patch set 26 11/12/25, 15:39

  70. core-ci voted on patch set 25 V +1 11/12/25, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89355

  71. core-ci voted on patch set 26 V +1 11/12/25, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89358

  72. Stefan Bürk uploaded patch set 27 V +1 11/13/25, 10:00

  73. core-ci voted on patch set 27 V +1 11/13/25, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89454

  74. Stefan Bürk uploaded patch set 28 V +1 11/13/25, 12:09

  75. core-ci voted on patch set 28 V +1 11/13/25, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89491

  76. Stefan Bürk uploaded patch set 29 V +1 11/13/25, 13:43

  1. Stefan Bürk wrote 11/13/25, 13:50

    Topic set to upgrade-wizards
  2. core-ci voted on patch set 29 V +1 11/13/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89508

  3. Stefan Bürk rebased onto patch set 30 V +1 11/13/25, 14:02

  4. core-ci voted on patch set 30 V +1 11/13/25, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89513

  5. Stefan Bürk rebased onto patch set 31 V +1 11/13/25, 19:32

  6. core-ci voted on patch set 31 V +1 11/13/25, 19:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89573

  7. Stefan Bürk rebased onto patch set 32 V +1 11/14/25, 08:26

  8. core-ci voted on patch set 32 V +1 11/14/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89661

  9. Stefan Bürk rebased onto patch set 33 V +1 11/14/25, 19:49

  10. core-ci voted on patch set 33 V +1 11/14/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89717

  11. Stefan Bürk uploaded patch set 34 V +1 11/24/25, 15:19

  12. core-ci voted on patch set 34 V +1 11/24/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90856

  13. Stefan Bürk rebased onto patch set 35 V +1 11/24/25, 15:54

  14. core-ci voted on patch set 35 V +1 11/24/25, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90864

  15. Stefan Bürk commented on patch set 35 11/24/25, 16:36

    This change is ready for review.

    Reply

    Changed the deprecation strategy and kept this v14 only in a non-breaking way.
  16. Sven Liebert voted on patch set 35 CR +1 V +1 11/24/25, 16:50

  17. Garvin Hicking commented on patch set 35 CR -1 11/24/25, 18:15

    on it, hang on
  18. Garvin Hicking uploaded patch set 36 CR +1 V +1 11/24/25, 18:41

  19. Garvin Hicking commented on patch set 36 CR +1 V +1 11/24/25, 18:42

    "works on my machine"
  20. Garvin Hicking commented on patch set 36 11/24/25, 18:42

    Reply

    Done

    Reply

    Done
  21. Sven Liebert voted on patch set 36 CR +1 V +1 11/24/25, 18:46

  22. core-ci voted on patch set 36 V +1 11/24/25, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90886

  23. Stefan Bürk voted on patch set 36 CR +2 V +2 11/24/25, 18:53

  24. Stefan Bürk merged patch set 37 11/24/25, 18:53

  25. Lina Wolf commented on patch set 37 12/01/25, 06:00