Review main Merged

89703[TASK] Fine-tune some context aspect classes

Christian Kuhn CR +2 V +2 Normal +26 −67 updated 06/11/25, 15:29

Commit message

* Use constructor property promotion
* Declare readonly: The entire state is set by __construct
* Declare final: These DO's are a contract and can not be
  overriden or extended
* Private properties: Final classes can and should use
  private properties
* Declare get() return values: Declaring per class is
  more fine-grained than 'mixed' from the interface

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Werner Starjakob +1
    • Manuel Zoli +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1217

  1. Christian Kuhn uploaded patch set 1 06/11/25, 10:19

  2. Christian Kuhn updated the commit message in patch set 2 06/11/25, 10:20

  3. Christian Kuhn updated the commit message in patch set 3 06/11/25, 10:22

  4. Christian Kuhn uploaded patch set 4 06/11/25, 10:23

  5. Christian Kuhn updated the commit message in patch set 5 06/11/25, 10:30

  6. core-ci voted on patch set 2 V +1 06/11/25, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80188

  7. core-ci voted on patch set 3 V +1 06/11/25, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80189

  8. core-ci voted on patch set 1 V +1 06/11/25, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80187

  9. core-ci voted on patch set 4 V +1 06/11/25, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80190

  10. core-ci voted on patch set 5 V +1 06/11/25, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80191

  11. Benni Mack voted on patch set 5 CR +1 V +1 06/11/25, 11:33

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 06/11/25, 12:18

  13. Oliver Klee voted on patch set 5 CR +1 06/11/25, 13:20

  14. Christian Kuhn voted on patch set 5 CR +2 V +2 06/11/25, 15:20

  15. Werner Starjakob voted on patch set 5 CR +1 06/11/25, 15:24

  16. Manuel Zoli voted on patch set 5 CR +1 06/11/25, 15:26

  17. Christian Kuhn merged patch set 6 06/11/25, 15:29