Review 13.4 Merged

89707[TASK] Fine-tune some context aspect classes

Christian Kuhn CR +2 V +2 Normal +26 −67 updated 06/11/25, 15:29

Commit message

* Use constructor property promotion
* Declare readonly: The entire state is set by __construct
* Declare final: These DO's are a contract and can not be
  overriden or extended
* Private properties: Final classes can and should use
  private properties
* Declare get() return values: Declaring per class is
  more fine-grained than 'mixed' from the interface

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/11/25, 15:21

  2. core-ci voted on patch set 1 V +1 06/11/25, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80209

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/11/25, 15:29

  4. Christian Kuhn merged patch set 2 06/11/25, 15:29