Review 13.4 Merged

89711[BUGFIX] Store and process site settings.yaml as a map

Benjamin Franzke CR +2 V +2 Hard +626 −211 updated 07/04/25, 06:58

Commit message

Site settings are defined as a map of keys, with a defined
type and default.

The values are currently stored as a tree representation in
`settings.yaml` (where tree nodes are generated from dot
separators in setting keys).

This tree representation is easier to write, but has the
drawback that arbitrary keys like `foo.bar` and `foo.bar.baz`
exclude each other, as the subkey `baz` would be represented
as a value of `foo.bar` in tree representation.

Note that TypoScript constants can express subkey constants since
TypoScript can store a value and childnodes for every node, which
means that existing extensions – that migrate to site sets – require
this mixture of setting identifiers to be supported in order to
avoid breaking existing settings.

The storage format of settings.yaml is now changed to use
a map (like settings.definitions.yaml already do) to store
setting values, in order to overcome the mentioned limitation.
It is still supported to *read* from a tree, but the settings editor
will convert the tree to a map when persisting values.

Existing anonymous setting (pre v13 style, e.g. settings without a
matching settings.definitions.yaml definition) will be preserved as
a tree, since it is not known which tree node is key or a value.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1424

  1. Benjamin Franzke uploaded patch set 1 06/12/25, 08:08

  2. core-ci voted on patch set 1 V +1 06/12/25, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80236

  3. Benjamin Franzke uploaded patch set 2 V +1 06/12/25, 09:11

  4. core-ci voted on patch set 2 V +1 06/12/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80239

  5. Benjamin Franzke uploaded patch set 3 V +1 06/12/25, 10:02

  6. core-ci voted on patch set 3 V +1 06/12/25, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80240

  7. Benjamin Franzke uploaded patch set 4 V +1 06/13/25, 10:56

  8. core-ci voted on patch set 4 V +1 06/13/25, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80284

  9. Benjamin Franzke uploaded patch set 5 V +1 06/13/25, 13:37

  10. core-ci voted on patch set 5 V +1 06/13/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80291

  11. Benjamin Franzke uploaded patch set 6 V +1 06/17/25, 07:20

  12. core-ci voted on patch set 6 V +1 06/17/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80411

  13. Benjamin Franzke uploaded patch set 7 V +1 06/17/25, 07:27

  14. core-ci voted on patch set 7 V +1 06/17/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80412

  15. Benjamin Franzke commented on patch set 8 V +1 06/17/25, 09:41

    Cherry Picked from branch main.
  16. core-ci voted on patch set 8 V +1 06/17/25, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80418

  17. Benjamin Franzke marked it work in progress 06/17/25, 09:52

  18. Benjamin Franzke commented on patch set 9 V +1 06/20/25, 13:01

    Cherry Picked from branch main.
  19. Benjamin Franzke marked it work in progress 06/20/25, 13:01

  20. core-ci voted on patch set 9 V +1 06/20/25, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80532

  21. Benjamin Franzke commented on patch set 10 V +1 07/04/25, 06:33

    Cherry Picked from branch main.
  22. Benjamin Franzke voted on patch set 10 CR +2 V +2 07/04/25, 06:35

  23. core-ci voted on patch set 10 V +1 07/04/25, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81309

  24. Benjamin Franzke merged patch set 11 07/04/25, 06:58