89711[BUGFIX] Store and process site settings.yaml as a map
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 21
- typo3/sysext/core/Classes/Settings/Settings.php+3 −4
- typo3/sysext/core/Classes/Settings/SettingsDiff.phprenamed+27 −16
- typo3/sysext/core/Classes/Settings/SettingsFactory.phpnew+96 −0
- typo3/sysext/core/Classes/Settings/SettingsProviderInterface.phpnew+35 −0
- typo3/sysext/core/Classes/Settings/SettingValue.phpnew+30 −0
- typo3/sysext/core/Classes/Site/Entity/SiteSettings.php+50 −26
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php+26 −112
- typo3/sysext/core/Classes/Site/SiteSettingsProvider.phpnew+109 −0
- typo3/sysext/core/Classes/Site/SiteSettingsService.php+24 −11
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103437-IntroduceSiteSets.rst+1 −3
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-106894-SiteSettingsyamlIsNowStoredAsAMap.rstnew+75 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/LegacySettingsTree/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/LegacySettingsTree/settings.definitions.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/LegacySettingsTree/settings.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/SettingsMap/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/SettingsMap/settings.definitions.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/SettingsMap/settings.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Site/Entity/SiteSettingsTest.php+94 −1
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Settings/SettingsDiffTest.phprenamed+35 −34
Review log 1424
-
Benjamin Franzke uploaded patch set 1 06/12/25, 08:08
-
core-ci voted on patch set 1 V +1 06/12/25, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80236
-
Benjamin Franzke uploaded patch set 2
V +106/12/25, 09:11 -
core-ci voted on patch set 2 V +1 06/12/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80239
-
Benjamin Franzke uploaded patch set 3
V +106/12/25, 10:02 -
core-ci voted on patch set 3 V +1 06/12/25, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80240
-
Benjamin Franzke uploaded patch set 4
V +106/13/25, 10:56 -
core-ci voted on patch set 4 V +1 06/13/25, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80284
-
Benjamin Franzke uploaded patch set 5
V +106/13/25, 13:37 -
core-ci voted on patch set 5 V +1 06/13/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80291
-
Benjamin Franzke uploaded patch set 6
V +106/17/25, 07:20 -
core-ci voted on patch set 6 V +1 06/17/25, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80411
-
Benjamin Franzke uploaded patch set 7
V +106/17/25, 07:27 -
core-ci voted on patch set 7 V +1 06/17/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80412
-
Benjamin Franzke commented on patch set 8
V +106/17/25, 09:41Cherry Picked from branch main. -
core-ci voted on patch set 8 V +1 06/17/25, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80418
-
Benjamin Franzke marked it work in progress 06/17/25, 09:52
-
Benjamin Franzke commented on patch set 9
V +106/20/25, 13:01Cherry Picked from branch main. -
Benjamin Franzke marked it work in progress 06/20/25, 13:01
-
core-ci voted on patch set 9 V +1 06/20/25, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80532
-
Benjamin Franzke commented on patch set 10
V +107/04/25, 06:33Cherry Picked from branch main. -
Benjamin Franzke voted on patch set 10 CR +2 V +2 07/04/25, 06:35
-
core-ci voted on patch set 10 V +1 07/04/25, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81309
-
Benjamin Franzke merged patch set 11 07/04/25, 06:58