Review main Merged

89713[TASK] Simplify LabelCapability

Oli Bartsch CR +2 V +2 Normal +84 −106 updated 06/12/25, 16:32

Commit message

The LabelCapability used `FieldTypeInterface`
objects instead of just the related field names.

This in the past (#106362) already required to
introduce the `SystemInternalFieldType` to
handle fields, not configured as TCA column,
e.g. `uid`.

Since it has been observed, that basically all
usages of the LabelCapability always access the
`getName()` method of the fields, this patch
now simplifies the LabelCapability by just
providing the configured field names.

There are only two places where the actual field
is evaluated. This is however easily possible
by just fetching the field via the TcaSchema
with `getField()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 812

  1. Oli Bartsch uploaded patch set 1 06/12/25, 11:15

  2. core-ci voted on patch set 1 V +1 06/12/25, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80245

  3. Oli Bartsch uploaded patch set 2 V +1 06/12/25, 11:39

  4. Oli Bartsch uploaded patch set 3 06/12/25, 11:48

  5. core-ci voted on patch set 2 V -1 06/12/25, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80250

  6. Oli Bartsch uploaded patch set 4 06/12/25, 12:07

  7. core-ci voted on patch set 3 V -1 06/12/25, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80251

  8. core-ci voted on patch set 4 V +1 06/12/25, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80253

  9. Benni Mack voted on patch set 4 CR +1 V +1 06/12/25, 15:21

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 06/12/25, 15:54

  11. Oli Bartsch voted on patch set 4 CR +2 V +2 06/12/25, 16:32

  12. Oli Bartsch merged patch set 5 06/12/25, 16:32