Review main Merged

89716[TASK] Make extbase Typo3DbQueryParser less stateful

Christian Kuhn CR +2 V +2 Normal +19 −42 updated 06/13/25, 08:45

Commit message

Extbase still relies on many stateful services, making
tracking of state very hard within the framework.

The patch cleans up Typo3DbQueryParser to reduce headaches
a bit:

* Property tableName was unused and is removed.
* PageRepository is created on demand and not parked
  in a property.
* Temporary state created while calling public
  convertQueryToDoctrineQueryBuilder() is reset
  in the end.
* We can not get rid of suggestDistinctQuery easily, but
  we can make sure it is reset when
  convertQueryToDoctrineQueryBuilder() is called another
  time to not leak state from a previous call.

Note the class is still kept shared:false because the
DataMapper dependency is stateful. It looks as if
it would be great to resolve this as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 06/12/25, 12:42

  2. core-ci voted on patch set 1 V +1 06/12/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80254

  3. Christian Kuhn uploaded patch set 2 V +1 06/12/25, 13:20

  4. core-ci voted on patch set 2 V +1 06/12/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80255

  5. Oliver Klee updated the commit message in patch set 3 V +1 06/12/25, 13:34

  6. core-ci voted on patch set 3 V +1 06/12/25, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80256

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 06/12/25, 17:40

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 06/13/25, 08:38

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 06/13/25, 08:45

  10. Christian Kuhn merged patch set 4 06/13/25, 08:45