Review main Merged

89719[TASK] Streamline workspace module ajax dispatching

Christian Kuhn CR +2 V +2 Nightmare +1206 −2013 updated 06/17/25, 10:35

Commit message

This is a refactoring patch of the ext:workspaces
controller logic.

Direct calls are easier to follow than indirect magic.

The main logic of the workspace main backend module and the
preview module is this: Have a main controller to create the
main scaffolding, then have an ajax dispatcher that responds
to user actions.

The goal of this change is to make code related to the ajax
actions more straight, more easy to follow, and easier to refactor.
Single actions were "anonymous" calls spread
into three different classes. These are now explicit calls
inlined to the main ajax controller, removing ambiguity.

Notable changes:
* Removed as unused: ActionHandler->generateWorkspacePreviewLink(),
  ActionHandler->saveColumnModel(), ActionHandler->loadColumnModel()
* Merge Controller/Remote/MassActionHandler into AjaxDispatcher
* Merge Controller/Remote/ActionHandler into AjaxDispatcher
* Merge Controller/Remote/RemoteServer->getRowDetails() into
  GridDataService to prevent a circular dependency between the two
  services
* Avoid WorkspaceService->getCurrentWorkspace() in favor
  of BackendUser->workspace
* Remove some heavily mocking unit test that don't add much value.
* The TypeScript side no longer needs the 'action' distinction to
  dispatch to different server side classes and can be simplified
* Rename AjaxController to WorkspacesToolbarController to clarify
  the job of this controller
* Rename AjaxDispatcher to WorkspacesAjaxController to make the
  class name more unique
* Tighten visibility of controllers, injections and helper methods
* Inline abstracted calls like processTcaCmd() to single controller
  actions to make more clear which single actions may miss proper
  error handling

Further notes:
* The PHP side still tends to create various information for single
  actions that are unused on the client side
* There is no handling on the client side to act upon server side
  error conditions
* Server side errors are not always escalated to the client side
* The 'mass action' functionality is an obvious area that should
  receive UI and handling changes

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 4480

Show 2855 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/13/25, 08:18

  2. core-ci voted on patch set 1 V -1 06/13/25, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80276

  3. Christian Kuhn uploaded patch set 2 V -1 06/13/25, 14:47

  4. core-ci voted on patch set 2 V -1 06/13/25, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80294

  5. Christian Kuhn uploaded patch set 3 V -1 06/13/25, 15:21

  6. core-ci voted on patch set 3 V -1 06/13/25, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80296

  7. Christian Kuhn uploaded patch set 4 V -1 06/13/25, 15:32

  8. Christian Kuhn uploaded patch set 5 06/13/25, 15:36

  9. core-ci voted on patch set 4 V +1 06/13/25, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80297

  10. core-ci voted on patch set 5 V +1 06/13/25, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80298

  11. Christian Kuhn uploaded patch set 6 V +1 06/13/25, 17:13

  12. core-ci voted on patch set 6 V +1 06/13/25, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80299

  13. Christian Kuhn uploaded patch set 7 V +1 06/13/25, 17:49

  14. core-ci voted on patch set 7 V +1 06/13/25, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80300

  15. Christian Kuhn uploaded patch set 8 V +1 06/13/25, 17:57

  16. core-ci voted on patch set 8 V +1 06/13/25, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80301

  17. Christian Kuhn uploaded patch set 9 V +1 06/13/25, 18:09

  18. core-ci voted on patch set 9 V +1 06/13/25, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80302

  19. Christian Kuhn uploaded patch set 10 V +1 06/13/25, 18:20

  20. core-ci voted on patch set 10 V +1 06/13/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80303

  21. Christian Kuhn uploaded patch set 11 V +1 06/13/25, 18:29

  22. core-ci voted on patch set 11 V +1 06/13/25, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80304

  23. Christian Kuhn uploaded patch set 12 V +1 06/13/25, 18:49

  24. Christian Kuhn uploaded patch set 13 06/13/25, 18:53

  25. core-ci voted on patch set 12 V +1 06/13/25, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80305

  26. core-ci voted on patch set 13 V +1 06/13/25, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80306

  27. Christian Kuhn uploaded patch set 14 V +1 06/13/25, 19:51

  28. Christian Kuhn uploaded patch set 15 06/13/25, 19:52

  29. core-ci voted on patch set 14 V +1 06/13/25, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80307

  30. core-ci voted on patch set 15 V +1 06/13/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80308

  31. Christian Kuhn uploaded patch set 16 V +1 06/15/25, 07:50

  32. core-ci voted on patch set 16 V +1 06/15/25, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80334

  33. Christian Kuhn uploaded patch set 17 V +1 06/15/25, 08:36

  34. core-ci voted on patch set 17 V -1 06/15/25, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80335

  35. Christian Kuhn uploaded patch set 18 V -1 06/15/25, 09:05

  36. core-ci voted on patch set 18 V -1 06/15/25, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80336

  37. Christian Kuhn uploaded patch set 19 V -1 06/15/25, 09:35

  38. Christian Kuhn uploaded patch set 20 06/15/25, 09:38

  39. core-ci voted on patch set 19 V -1 06/15/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80337

  40. core-ci voted on patch set 20 V -1 06/15/25, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80338

  41. Christian Kuhn uploaded patch set 21 V -1 06/15/25, 10:18

  42. core-ci voted on patch set 21 V -1 06/15/25, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80339

  43. Christian Kuhn uploaded patch set 22 V -1 06/15/25, 10:40

  44. core-ci voted on patch set 22 V -1 06/15/25, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80340

  45. Christian Kuhn uploaded patch set 23 V -1 06/15/25, 11:13

  46. core-ci voted on patch set 23 V +1 06/15/25, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80341

  47. Christian Kuhn uploaded patch set 24 V +1 06/15/25, 11:58

  48. core-ci voted on patch set 24 V +1 06/15/25, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80344

  49. Christian Kuhn uploaded patch set 25 V +1 06/15/25, 12:15

  50. Christian Kuhn uploaded patch set 26 06/15/25, 12:22

  51. core-ci voted on patch set 25 V +1 06/15/25, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80346

  52. core-ci voted on patch set 26 V +1 06/15/25, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80347

  53. Christian Kuhn updated the commit message in patch set 27 V +1 06/15/25, 12:42

  54. Christian Kuhn updated the commit message in patch set 28 06/15/25, 12:44

  55. core-ci voted on patch set 27 V +1 06/15/25, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80348

  1. core-ci voted on patch set 28 V +1 06/15/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80349

  2. Christian Kuhn uploaded patch set 29 V +1 06/15/25, 12:57

  3. Christian Kuhn updated the commit message in patch set 30 06/15/25, 13:01

  4. core-ci voted on patch set 29 V +1 06/15/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80350

  5. Christian Kuhn uploaded patch set 31 06/15/25, 13:06

  6. Christian Kuhn updated the commit message in patch set 32 06/15/25, 13:08

  7. Garvin Hicking updated the commit message in patch set 33 06/15/25, 13:09

  8. core-ci voted on patch set 30 V +1 06/15/25, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80351

  9. core-ci voted on patch set 31 V +1 06/15/25, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80352

  10. core-ci voted on patch set 32 V +1 06/15/25, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80353

  11. core-ci voted on patch set 33 V +1 06/15/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80354

  12. Stefan Bürk voted on patch set 33 CR +1 06/16/25, 11:01

  13. Simon Schaufelberger uploaded patch set 34 CR +1 V +1 06/16/25, 11:18

  14. Simon Schaufelberger uploaded patch set 35 06/16/25, 11:20

  15. core-ci voted on patch set 34 V +1 06/16/25, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80377

  16. core-ci voted on patch set 35 V +1 06/16/25, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80378

  17. Stefan Bürk voted on patch set 35 CR +1 V +1 06/16/25, 11:50

  18. Garvin Hicking voted on patch set 35 CR +1 V +1 06/17/25, 09:37

  19. Christian Kuhn commented on patch set 35 06/17/25, 10:22

    hmm. we had quite a few refactorings in main that make it hard to backport this change to v13. i think we should rather omit v13 on this one since the backport is a bit to risky and/or quite a lot of work to get right.
  20. Christian Kuhn updated the commit message in patch set 36 CR +1 V +1 06/17/25, 10:23

  21. Stefan Bürk voted on patch set 36 CR +1 V +1 06/17/25, 10:24

  22. Garvin Hicking voted on patch set 36 CR +1 V +1 06/17/25, 10:27

  23. core-ci voted on patch set 36 V +1 06/17/25, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80420

  24. Christian Kuhn voted on patch set 36 CR +2 V +2 06/17/25, 10:35

  25. Christian Kuhn merged patch set 37 06/17/25, 10:35