89721[TASK] Clean up some workspace module details
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Stefan Froemken +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 5
Review log 1216
-
Christian Kuhn uploaded patch set 1 06/13/25, 09:06
-
core-ci voted on patch set 1 V -1 06/13/25, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80280
-
Christian Kuhn uploaded patch set 2
V -106/13/25, 09:27 -
core-ci voted on patch set 2 V -1 06/13/25, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80281
-
Christian Kuhn updated the commit message in patch set 3
V -106/13/25, 09:40 -
Christian Kuhn voted on patch set 3 CR -1 06/13/25, 09:40
-
core-ci voted on patch set 3 V -1 06/13/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80283
-
Christian Kuhn uploaded patch set 4
CR -1V -106/13/25, 10:59 -
core-ci voted on patch set 4 V +1 06/13/25, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80285
-
Stefan Bürk voted on patch set 4 CR +1 06/13/25, 11:26
-
Stefan Bürk voted on patch set 4 V +1 06/13/25, 12:31
-
Stefan Froemken voted on patch set 4 CR +1 06/13/25, 12:33
-
Stefan Froemken commented on patch set 4 V +1 06/13/25, 12:47
OK. Verified. Requests does not contain tid and type anymore. I cannot find any left overs or usages of "tid" anymore. "type" seems just to be an old marker to inform AJAX requests HOW to open the connection. With TYPO3 AjaxRequest this is not needed anymore. Workspace module is still working ;-) I only miss an icon "expand element and show relation", but that is also missing on main branch. So, nothing to take care here in that patch. -
Christian Kuhn commented on patch set 4 06/13/25, 12:53
Reply
the icon is only rendered for elements that do have changed relations. -
Christian Kuhn voted on patch set 4 CR +2 V +2 06/13/25, 13:39
-
Christian Kuhn merged patch set 5 06/13/25, 13:39