Review main Merged

89721[TASK] Clean up some workspace module details

Christian Kuhn CR +2 V +2 Easy +7 −26 updated 06/13/25, 13:39

Commit message

* JS 'type' and 'tid' are probably remnants from
  extjs without any functionality being attached
  to it. Removed.
* TYPO3.settings.Workspaces.token is never set in
  PHP and always null. Removed.
* TYPO3.settings.Workspaces.icons is set in PHP but
  never used in JS. Removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1216

  1. Christian Kuhn uploaded patch set 1 06/13/25, 09:06

  2. core-ci voted on patch set 1 V -1 06/13/25, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80280

  3. Christian Kuhn uploaded patch set 2 V -1 06/13/25, 09:27

  4. core-ci voted on patch set 2 V -1 06/13/25, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80281

  5. Christian Kuhn updated the commit message in patch set 3 V -1 06/13/25, 09:40

  6. Christian Kuhn voted on patch set 3 CR -1 06/13/25, 09:40

  7. core-ci voted on patch set 3 V -1 06/13/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80283

  8. Christian Kuhn uploaded patch set 4 CR -1 V -1 06/13/25, 10:59

  9. core-ci voted on patch set 4 V +1 06/13/25, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80285

  10. Stefan Bürk voted on patch set 4 CR +1 06/13/25, 11:26

  11. Stefan Bürk voted on patch set 4 V +1 06/13/25, 12:31

  12. Stefan Froemken voted on patch set 4 CR +1 06/13/25, 12:33

  13. Stefan Froemken commented on patch set 4 V +1 06/13/25, 12:47

    OK. Verified. Requests does not contain tid and type anymore. I cannot find any left overs or usages of "tid" anymore. "type" seems just to be an old marker to inform AJAX requests HOW to open the connection. With TYPO3 AjaxRequest this is not needed anymore. Workspace module is still working ;-) I only miss an icon "expand element and show relation", but that is also missing on main branch. So, nothing to take care here in that patch.
  14. Christian Kuhn commented on patch set 4 06/13/25, 12:53

    Reply

    the icon is only rendered for elements that do have changed relations.
  15. Christian Kuhn voted on patch set 4 CR +2 V +2 06/13/25, 13:39

  16. Christian Kuhn merged patch set 5 06/13/25, 13:39