Review main Merged

89723[BUGFIX] Prevent workspace module crash in history

Christian Kuhn CR +2 V +2 Easy +3 −0 updated 06/13/25, 12:25

Commit message

When workspaces pulls data from sys_history, some fields
that has been written to history_data['newRecord'] may
not exist anymore if TCA changed meanwhile. Sanitize this
when looking up TCA details in TcaSchema to prevent an
exception from $schema->getField().

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 06/13/25, 11:18

  2. Christian Kuhn updated the commit message in patch set 2 06/13/25, 11:19

  3. core-ci voted on patch set 1 V +1 06/13/25, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80286

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 06/13/25, 11:26

  5. core-ci voted on patch set 2 V +1 06/13/25, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80287

  6. Georg Ringer voted on patch set 2 CR +2 V +2 06/13/25, 11:57

  7. Georg Ringer merged patch set 3 06/13/25, 11:57

  8. Stefan Froemken commented on patch set 3 06/13/25, 12:13

    Tested in real-life: Exception is only thrown and catched internal. Workspace module does NOT crash...it just do not show records with old fields in newRecord array.
  9. Christian Kuhn commented on patch set 3 06/13/25, 12:25

    Reply

    i got a crash when i created a change for some record field, then unloaded the extension that brought this field, then called the ws-module.