Review main Merged

89725[TASK] Remove dead code from workspaces RemoteServer

Christian Kuhn CR +2 V +2 Easy +0 −29 updated 06/13/25, 14:29

Commit message

The 'type="all"' isn't triggered by the ajax calls
for a long time anymore. The code branch can be
safely removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 06/13/25, 12:46

  2. core-ci voted on patch set 1 V +1 06/13/25, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80289

  3. Stefan Froemken commented on patch set 1 CR +1 V +1 06/13/25, 13:46

    Last TYPO3 version where I can find this usage is TYPO3 8.0. With TYPO3 8.1 Andreas has refactored whole Workspaces module to jquery usage. While this migration the "all" usage gets lost (or not needed). So, yes, this part is not needed anymore since years. See also: https://github.com/TYPO3/typo3/commit/7bbb4178229f049f83fe0582bbc741623d60c4a5
  4. Christian Kuhn commented on patch set 1 06/13/25, 13:49

    Reply

    nice. thanks for digging further :)
  5. Stefan Bürk voted on patch set 1 CR +1 V +1 06/13/25, 14:17

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 06/13/25, 14:29

  7. Christian Kuhn merged patch set 2 06/13/25, 14:29