89729[FEATURE] Add f:format.cssVariables ViewHelper
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 3
Review log 1117
-
André Buchmann uploaded patch set 1 06/13/25, 14:53
-
André Buchmann marked it work in progress 06/13/25, 14:53
-
core-ci voted on patch set 1 V -1 06/13/25, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80295
-
André Buchmann uploaded patch set 2
V -106/16/25, 13:30 -
André Buchmann uploaded patch set 3 06/16/25, 13:36
-
core-ci voted on patch set 2 V -1 06/16/25, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80384
-
core-ci voted on patch set 3 V +1 06/16/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80385
-
André Buchmann marked it ready for review 06/16/25, 13:45
-
Oliver Klee updated the commit message in patch set 4
V +106/16/25, 15:34 -
core-ci voted on patch set 4 V +1 06/16/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80388
-
André Buchmann uploaded patch set 5
V +108/26/25, 09:43 -
core-ci voted on patch set 5 V -1 08/26/25, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83871
-
André Buchmann uploaded patch set 6
V -108/26/25, 09:57 -
core-ci voted on patch set 6 V +1 08/26/25, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83872
-
Simon Praetorius commented on patch set 6 08/27/25, 16:47
I think this can be a helpful tool in some circumstances. However, since the ViewHelper doesn't have any dependencies to TYPO3, it might be better suited for Fluid Standalone. Feel free to create a PR there.CssVariablesViewHelper.php:42UnresolvedCan you add `getContentArgumentName()` and the matching check for `renderChildren()`? Then the ViewHelper could also be used like this: ``` {variables -> f:format.cssVariables()}CssVariablesViewHelper.php:44UnresolvedNo need to mention the default value in the descriptionCssVariablesViewHelper.php:74UnresolvedWe can probably use `is_scalar()` here, maybe even a check for stringable? -
Simon Schaufelberger commented on patch set 6 01/17/26, 19:45
done in https://github.com/TYPO3/Fluid/pull/1229. Patch can be abandoned -
Garvin Hicking abandoned the change 01/17/26, 21:25