Review main Abandoned

89729[FEATURE] Add f:format.cssVariables ViewHelper

André Buchmann CR 0 V 0 Hard +294 −0 updated 01/17/26, 21:25

Commit message

This commit introduces a new Fluid ViewHelper `<f:format.cssVariables>`
to format array-structured data as CSS custom properties.

The ViewHelper is intended to be used within `<f:asset.css>` to
dynamically generate CSS variables from Fluid data, for example,
from site settings. This allows for more flexible and maintainable
theming.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 1117

  1. André Buchmann uploaded patch set 1 06/13/25, 14:53

  2. André Buchmann marked it work in progress 06/13/25, 14:53

  3. core-ci voted on patch set 1 V -1 06/13/25, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80295

  4. André Buchmann uploaded patch set 2 V -1 06/16/25, 13:30

  5. André Buchmann uploaded patch set 3 06/16/25, 13:36

  6. core-ci voted on patch set 2 V -1 06/16/25, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80384

  7. core-ci voted on patch set 3 V +1 06/16/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80385

  8. André Buchmann marked it ready for review 06/16/25, 13:45

  9. Oliver Klee updated the commit message in patch set 4 V +1 06/16/25, 15:34

  10. core-ci voted on patch set 4 V +1 06/16/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80388

  11. André Buchmann uploaded patch set 5 V +1 08/26/25, 09:43

  12. core-ci voted on patch set 5 V -1 08/26/25, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83871

  13. André Buchmann uploaded patch set 6 V -1 08/26/25, 09:57

  14. core-ci voted on patch set 6 V +1 08/26/25, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83872

  15. Simon Praetorius commented on patch set 6 08/27/25, 16:47

    I think this can be a helpful tool in some circumstances. However, since the ViewHelper doesn't have any dependencies to TYPO3, it might be better suited for Fluid Standalone. Feel free to create a PR there.

    CssVariablesViewHelper.php:42 Unresolved

    Can you add `getContentArgumentName()` and the matching check for `renderChildren()`? Then the ViewHelper could also be used like this: ``` {variables -> f:format.cssVariables()}

    CssVariablesViewHelper.php:44 Unresolved

    No need to mention the default value in the description

    CssVariablesViewHelper.php:74 Unresolved

    We can probably use `is_scalar()` here, maybe even a check for stringable?
  16. Simon Schaufelberger commented on patch set 6 01/17/26, 19:45

    done in https://github.com/TYPO3/Fluid/pull/1229. Patch can be abandoned
  17. Garvin Hicking abandoned the change 01/17/26, 21:25