89732[BUGFIX] Streamline type of buttons within backend button bar
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1113
-
Elias Häußler uploaded patch set 1 06/15/25, 11:33
-
Elias Häußler uploaded patch set 2 06/15/25, 11:36
-
core-ci voted on patch set 1 V -1 06/15/25, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80342
-
core-ci voted on patch set 2 V +1 06/15/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80343
-
Oliver Klee voted on patch set 2 CR +1 V +1 06/15/25, 11:53
-
Georg Ringer commented on patch set 2 CR -1 06/16/25, 05:21
ModifyButtonBarEvent.php:28IMO this is correctModifyButtonBarEvent.php:33not needed, we got a return type alreadyModifyButtonBarEvent.php:41not needed, we got a return type already -
Georg Ringer voted on patch set 2 CR 0 06/16/25, 05:21
-
Elias Häußler commented on patch set 2 06/16/25, 05:36
ButtonBar.php:49Reply`Buttons` is a custom PHPStan type (see line 32) which is used here. I did this to avoid repeating the rather complex array structure at every place. I think this may also answer your other comments. -
Georg Ringer voted on patch set 2 CR +1 V +1 06/16/25, 19:21
-
Markus Klein commented on patch set 2 CR +1 V +1 06/17/25, 06:37
ButtonBar.php:49ReplyDoneModifyButtonBarEvent.php:28ReplyDoneModifyButtonBarEvent.php:33ReplyDoneModifyButtonBarEvent.php:41ReplyDone -
Christian Kuhn voted on patch set 2 CR +1 06/17/25, 10:30
-
Christian Kuhn commented on patch set 2 CR +2 V +2 06/17/25, 16:34
i'll gonna merge this when v13 and v12 are green. note i'd usually not accept this for v12 anymore. however, considering the change is (nearly) completely comment-only and thus low-risk, i'll accept the v12 request in this case. -
Christian Kuhn merged patch set 3 06/17/25, 17:46
ButtonBar.php:49