Review main Abandoned Breaking

89733[!!!][TASK] Modernize registration and handling of buttons in button bar

Elias Häußler CR 0 V 0 Hard +312 −645 updated 10/24/25, 16:46

Commit message

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Files 46

Show 26 more files

Review log 1219

  1. Elias Häußler uploaded patch set 1 06/15/25, 16:06

  2. core-ci voted on patch set 1 V +1 06/15/25, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80355

  3. Benni Mack commented on patch set 1 07/29/25, 21:34

    ButtonPosition.php:23

    should we start with "start" and "end" similar to the CSS changes
  4. Elias Häußler uploaded patch set 2 V +1 08/04/25, 08:47

  5. Elias Häußler uploaded patch set 3 08/04/25, 08:49

  6. core-ci voted on patch set 2 V +1 08/04/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82725

  7. core-ci voted on patch set 3 V +1 08/04/25, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82726

  8. Elias Häußler uploaded patch set 4 V +1 08/04/25, 09:39

  9. Elias Häußler commented on patch set 4 08/04/25, 09:40

    This change is ready for review.

    ButtonPosition.php:23 Reply Unresolved

    Thanks for this suggestion! I applied it and changed CSS classes as well. Do you think that this goes into the right direction? (See here for the left/right -> start/end change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89733/3..4)
  10. Elias Häußler marked it work in progress 08/04/25, 09:40

  11. core-ci voted on patch set 4 V -1 08/04/25, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82734

  12. Elias Häußler uploaded patch set 5 V -1 08/04/25, 09:57

  13. core-ci voted on patch set 5 V +1 08/04/25, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82738

  14. Elias Häußler uploaded patch set 6 V +1 08/25/25, 13:03

  15. core-ci voted on patch set 6 V -1 08/25/25, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83847

  16. Elias Häußler uploaded patch set 7 V -1 09/10/25, 18:49

  17. core-ci voted on patch set 7 V +1 09/10/25, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84797

  18. Garvin Hicking wrote 10/13/25, 07:11

    Topic set to buttonbar
  19. Elias Häußler abandoned the change 10/24/25, 16:46