Review main Merged

89735[BUGFIX] Preserve includeScheduledRecords in PreviewSimulator

Werner Starjakob CR +2 V +2 Easy +1 −1 updated 06/17/25, 10:05

Commit message

The context object aspects are set up by various middlewares.
The middleware chain can be manipulated and extended, core
middlewares don't know if a previous middleware may have set
up single aspects already.
Single middlewares thus test aspect existance and reset
only single flags while preserving others. This preservation
strategy is not done for the includeScheduledRecords flag
of VisibilityAspect in PreviewSimulator middleware. The
patch adds this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Werner Starjakob uploaded patch set 1 06/16/25, 08:18

  2. core-ci voted on patch set 1 V +1 06/16/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80370

  3. Georg Ringer voted on patch set 1 CR +1 V +1 06/17/25, 04:45

  4. Christian Kuhn commented on patch set 1 06/17/25, 08:41

    thanks for your first patch Werner! I'm fine with the change but will tune the commit message a bit.
  5. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 06/17/25, 08:48

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 06/17/25, 08:48

  7. core-ci voted on patch set 2 V +1 06/17/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80414

  8. Georg Ringer voted on patch set 2 CR +1 V +1 06/17/25, 08:58

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 06/17/25, 09:07

  10. Christian Kuhn merged patch set 3 06/17/25, 10:05