Review main Merged

89737[BUGFIX] Placeholders in error messages are not replaced

Simon Schaufelberger CR +2 V +2 Easy +37 −1 updated 08/22/25, 15:53

Commit message

The general \Exception class doesn't know anything about placeholders.
Therefore, any given placeholder in the error message must be replaced
before creating a general exception message.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Simon Schaufelberger uploaded patch set 1 06/16/25, 11:40

  2. core-ci voted on patch set 1 V -1 06/16/25, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80380

  3. Simon Schaufelberger uploaded patch set 2 V -1 06/16/25, 11:58

  4. core-ci voted on patch set 2 V +1 06/16/25, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80381

  5. Oliver Klee voted on patch set 2 CR +1 V +1 06/16/25, 12:28

  6. Garvin Hicking commented on patch set 2 06/17/25, 06:34

    Do you have a use case where the core uses placeholders for this typeconverter? All places I see use sprintf() for throwing the exception. I guess it's to allow third party code to use placeholders there? In that case we should mark this patch as a task, not a bugfix. But I wonder where the core actually uses "native" placeholders, because this sprintf() seems to be much more common? (honest question)
  7. Simon Schaufelberger commented on patch set 2 08/18/25, 19:30

    Reply

    I don't have a concrete use case but I had a custom typeconverter that copied this "wrong" behavior and when fixing it, I noticed that it's broken by design. The core doesn't use this broken pattern but provides the opportunity to use placeholders which don't work as expected.
  8. Simon Schaufelberger commented on patch set 2 08/19/25, 07:39

    Reply

    Done
  9. Stefan Froemken voted on patch set 2 CR +1 V +1 08/22/25, 08:55

  10. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 08/22/25, 15:21

  11. Christian Kuhn rebased onto patch set 4 08/22/25, 15:21

  12. Christian Kuhn commented on patch set 4 08/22/25, 15:22

    hey. i hope it is ok to not backport this to v12 anymore.
  13. Christian Kuhn voted on patch set 4 CR +2 V +2 08/22/25, 15:22

  14. core-ci voted on patch set 3 V +1 08/22/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83772

  15. core-ci voted on patch set 4 V +1 08/22/25, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83773

  16. Christian Kuhn commented on patch set 4 08/22/25, 15:53

    i hope merge ok here with taking the votes for the previous patch set into account: i only removed v12 from the commit message since the change is not a critical fix.
  17. Christian Kuhn merged patch set 5 08/22/25, 15:53