Review 13.4 Merged

89748[BUGFIX] Streamline type of buttons within backend button bar

Christian Kuhn CR +2 V +2 Easy +14 −6 updated 06/17/25, 17:46

Commit message

The buttons added to the backend button bar can be modified through a
`ModifyButtonBarEvent`. Buttons, which were initially added to the
button bar using the `ButtonBar::addButton` method, are sorted by
position and group. This array structure was not properly reflected in
the `ModifyButtonBarEvent`, which is now fixed by introducing a
dedicated PHPStan type for the rather complex array structure.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/17/25, 16:30

  2. core-ci voted on patch set 1 V +1 06/17/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80436

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/17/25, 17:46

  4. Christian Kuhn merged patch set 2 06/17/25, 17:46