89750[TASK] Use markdown to render better Live Search hints
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/Sass/component/_livesearch.scss2+10 −0
- Build/Sources/TypeScript/backend/live-search/element/hint.tsnew+33 −0
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+1 −0
- Build/Sources/TypeScript/core/directive/markdown.ts+1 −1
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+7 −1
- typo3/sysext/backend/Resources/Private/Templates/LiveSearch/Form.html+1 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/hint.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf+3 −3
- typo3/sysext/core/Resources/Public/JavaScript/directive/markdown.js+1 −1
Review log 67
-
Andreas Kienast uploaded patch set 1 06/18/25, 05:57
-
core-ci voted on patch set 1 V +1 06/18/25, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80452
-
Benjamin Franzke commented on patch set 1 CR +1 V +1 06/18/25, 06:33
-
Andreas Kienast commented on patch set 1 06/18/25, 06:57
_livesearch.scss:32ReplyI can't quite follow. I was referring to markedjs's `parseInline` function which is currently not called by our markdown wrapper. -
Garvin Hicking commented on patch set 1 CR +1 V +1 06/18/25, 07:52
Nice. The keyboard shortcuts are well readable on lightmode https://www.dropbox.com/scl/fi/g7vjxe841xmykffvhj6pz/Screenshot-2025-06-18-at-09.51.58.png?rlkey=q2rosa4mpddphefjwi365d633&dl=0 but a bit harder on dark mode: https://www.dropbox.com/scl/fi/4sv4f423kp2yg569efjf8/Screenshot-2025-06-18-at-09.52.33.png?rlkey=gr0tw7dexracats9zfh1lcqpj&dl=0 I can live with that though. -
Andreas Kienast voted on patch set 1 CR +2 V +2 06/18/25, 07:58
-
Andreas Kienast merged patch set 2 06/18/25, 08:07
_livesearch.scss:32