Review main Merged

89750[TASK] Use markdown to render better Live Search hints

Andreas Kienast CR +2 V +2 Normal +73 −8 updated 06/18/25, 08:07

Commit message

The Live Search hints now support markdown-based texts to allow
emphasizing specific parts of their contents, e.g. highlighting input
suggestions or key strokes.

To enable rendering key stroke hints without allowing all HTML
available, the dompurify configuration used within the module
`@typo3/core/directive/markdown` needs to include `kbd` as an allowed
tag.

As the `markdown` module currently only renderes block content wrapped
in a `<p>` tag, some CSS changes became necessary.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 67

  1. Andreas Kienast uploaded patch set 1 06/18/25, 05:57

  2. core-ci voted on patch set 1 V +1 06/18/25, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80452

  3. Benjamin Franzke commented on patch set 1 CR +1 V +1 06/18/25, 06:33

    _livesearch.scss:32

    I'm not sure if we "really" want an inline mode, `marked` does support that (see https://github.com/markedjs/marked/issues/1388#issuecomment-447048317 where workarounds via postprocessing were recommended). Anyway, I can live with that todo. ;)
  4. Andreas Kienast commented on patch set 1 06/18/25, 06:57

    _livesearch.scss:32 Reply

    I can't quite follow. I was referring to markedjs's `parseInline` function which is currently not called by our markdown wrapper.
  5. Garvin Hicking commented on patch set 1 CR +1 V +1 06/18/25, 07:52

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 06/18/25, 07:58

  7. Andreas Kienast merged patch set 2 06/18/25, 08:07