89751[TASK] Remove import of `RecordTableElement` in workspaces backend
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 1
Review log 68
-
Andreas Kienast uploaded patch set 1 06/18/25, 06:05
-
core-ci voted on patch set 1 V +1 06/18/25, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80453
-
Benjamin Franzke updated the commit message in patch set 2
V +106/18/25, 06:40 -
Benjamin Franzke commented on patch set 2 CR +1 V +1 06/18/25, 06:40
No bug is fixed here.backend.ts:33Hm, that should have been detected by https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax to be a type-only import and therefore should have been `import type { RecordTableElement }` anyway. I guess it was not detected because the same module is imported in line 20 as well, and therefore also the build output didn't change. -
core-ci voted on patch set 2 V +1 06/18/25, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80454
-
Garvin Hicking voted on patch set 2 CR +1 V +1 06/18/25, 07:54
-
Andreas Kienast voted on patch set 2 CR +2 V +2 06/18/25, 07:58
-
Andreas Kienast merged patch set 3 06/18/25, 08:07