89754[TASK] Rework Live Search filtering
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1215
-
Andreas Kienast uploaded patch set 1 06/18/25, 09:55
-
Georg Ringer voted on patch set 1 CR +1 V +1 06/18/25, 09:59
-
core-ci voted on patch set 1 V +1 06/18/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80459
-
Benjamin Franzke commented on patch set 1 CR -1 06/19/25, 09:37
live-search.ts:237We're in a `async` method, we can use `try { await … } catch …`live-search.ts:241`unknown` is better as `any` here (since `unknown` makes it clear that it can not be used without prior checks)Form.html:12Now that changing the options update the results immediately, it is unneeded that the user has to close the filter dropdown by clicking on it. I'd prefer `data-bs-auto-close="outside"` here. -
Benjamin Franzke uploaded patch set 2
CR +1V +106/19/25, 09:54 -
Benjamin Franzke commented on patch set 2 06/19/25, 09:54
live-search.ts:232ReplyDonelive-search.ts:237ReplyDonelive-search.ts:241ReplyDoneForm.html:12ReplyDone -
core-ci voted on patch set 2 V -1 06/19/25, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80498
-
Benjamin Franzke uploaded patch set 3
CR +1V +106/19/25, 10:52 -
core-ci voted on patch set 3 V +1 06/19/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80501
-
Benjamin Franzke commented on patch set 3 06/20/25, 13:06
Form.html:14BTW, this badge is unattractively overlaid by the input focus border, of the search field. Maybe we can reiterate on that UI part while we are at it (or in a separate change). cc @benjamin.kott@outlook.com -
Andreas Kienast commented on patch set 3 06/23/25, 06:46
Form.html:14ReplyJust FYI: this seems to be a general issue with badges – we have a similar overlay bug in the top module menu as well. -
Benjamin Franzke commented on patch set 3 06/23/25, 08:41
Form.html:14Replyok, let's handle separately -
Benni Mack voted on patch set 3 CR +1 V +1 06/24/25, 06:24
-
Andreas Kienast voted on patch set 3 CR +2 V +2 06/24/25, 06:30
-
Andreas Kienast merged patch set 4 06/24/25, 06:41
live-search.ts:232