Review main Merged

89754[TASK] Rework Live Search filtering

Andreas Kienast CR +2 V +2 Easy +24 −13 updated 06/24/25, 06:41

Commit message

The filtering approach in the Live Search is refined to directly react
on user interaction when toggling a checkbox. Before, the user had to
close the filter dropdown, which is not in line with the search field
behavior as it doesn't require an explicit action.

If a user changes the search demand while a request is running, the
current request gets aborted to avoid letting the server handling
obsolete requests.

Also, to make the intention of the filter dropdown more clear, the
trigger icon is changed to an actual "filter" icon.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1215

  1. Andreas Kienast uploaded patch set 1 06/18/25, 09:55

  2. Georg Ringer voted on patch set 1 CR +1 V +1 06/18/25, 09:59

  3. core-ci voted on patch set 1 V +1 06/18/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80459

  4. Benjamin Franzke commented on patch set 1 CR -1 06/19/25, 09:37

    live-search.ts:232

    `!== null` would suffice. And even better: `this.currentSearchRequest?.abort()`

    live-search.ts:237

    We're in a `async` method, we can use `try { await … } catch …`

    live-search.ts:241

    `unknown` is better as `any` here (since `unknown` makes it clear that it can not be used without prior checks)

    Form.html:12

    Now that changing the options update the results immediately, it is unneeded that the user has to close the filter dropdown by clicking on it. I'd prefer `data-bs-auto-close="outside"` here.
  5. Benjamin Franzke uploaded patch set 2 CR +1 V +1 06/19/25, 09:54

  6. Benjamin Franzke commented on patch set 2 06/19/25, 09:54

    live-search.ts:232 Reply

    Done

    live-search.ts:237 Reply

    Done

    live-search.ts:241 Reply

    Done

    Form.html:12 Reply

    Done
  7. core-ci voted on patch set 2 V -1 06/19/25, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80498

  8. Benjamin Franzke uploaded patch set 3 CR +1 V +1 06/19/25, 10:52

  9. core-ci voted on patch set 3 V +1 06/19/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80501

  10. Benjamin Franzke commented on patch set 3 06/20/25, 13:06

    Form.html:14

    BTW, this badge is unattractively overlaid by the input focus border, of the search field. Maybe we can reiterate on that UI part while we are at it (or in a separate change). cc @benjamin.kott@outlook.com
  11. Andreas Kienast commented on patch set 3 06/23/25, 06:46

    Form.html:14 Reply

    Just FYI: this seems to be a general issue with badges – we have a similar overlay bug in the top module menu as well.
  12. Benjamin Franzke commented on patch set 3 06/23/25, 08:41

    Form.html:14 Reply

    ok, let's handle separately
  13. Benni Mack voted on patch set 3 CR +1 V +1 06/24/25, 06:24

  14. Andreas Kienast voted on patch set 3 CR +2 V +2 06/24/25, 06:30

  15. Andreas Kienast merged patch set 4 06/24/25, 06:41