89757[BUGFIX] Remove dedicated processed file for DnD thumbnail
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/filelist/file-list-actions.ts+5 −1
- typo3/sysext/filelist/Classes/Dto/ResourceView.php+0 −13
- typo3/sysext/filelist/Classes/FileList.php+4 −7
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/Tiles.html+1 −2
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-actions.js+1 −1
Review log 810
-
Markus Klein uploaded patch set 1 06/18/25, 13:20
-
core-ci voted on patch set 1 V -1 06/18/25, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80468
-
Markus Klein uploaded patch set 2
V -106/18/25, 16:08 -
Markus Klein commented on patch set 2 06/18/25, 16:09
This change is ready for review. -
core-ci voted on patch set 2 V +1 06/18/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80470
-
Andreas Kienast commented on patch set 2 06/24/25, 09:46
I'm undecided here. Using the already existing preview images may lead to broken thumbnails within the tooltip due to the required 1:1 aspect ratio. -
Markus Klein commented on patch set 2 06/24/25, 11:39
Reply Unresolved
Yes, but that really does not matter when we can save a processed file for every file in FAL! Please consider that being able to use the system is by far more important than a distorted thumbnail with 32px only used when dragging a file. With an S3 bucket, this patch combined with https://review.typo3.org/c/Packages/TYPO3.CMS/+/89755/ literally improves speed of loading a single folder by factor 5 on a production system (!!) -
Andreas Kienast commented on patch set 2 07/22/25, 08:40
I still don't think this patch solves the issue properly, but introduces a workaround instead. The thumbnail is here so it can be used at various places within EXT:filelist (spoiler alert: I'm currently building a patch doing this). I checked the code yesterday – there is a `DeferredBackendImageProcessor` in place that offloads the generation into a separate PHP process if required, so it should not (tm) affect the initial rendering of the filelist. Honestly, I consider blurred / distorted figures being a degradation in _visual_ quality of our product. -
Markus Klein commented on patch set 2 07/22/25, 09:03
Reply Unresolved
We talked via Slack, just a few words to sum up my POV for others: I do not care about "visual quality" until the product actually does its job, which is the problem here. I have no better suggestion to "fix/workaround/..." this issue. -
Markus Klein abandoned the change 07/24/25, 13:48