Review main Abandoned

89757[BUGFIX] Remove dedicated processed file for DnD thumbnail

Markus Klein CR 0 V 0 Easy +11 −24 updated 07/24/25, 13:48

Commit message

Remove the need for a dedicated processed file
as a thumbnail for drag and drop operations in
filelist module.

A separate processed file had been generated
for each file listed in the filelist module,
which was only used during drag and drop
operations.

This dedicated thumbnail is now omitted.
It uses any existing thumbnail from list or
tile view during the DnD operation.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 5

Review log 810

  1. Markus Klein uploaded patch set 1 06/18/25, 13:20

  2. core-ci voted on patch set 1 V -1 06/18/25, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80468

  3. Markus Klein uploaded patch set 2 V -1 06/18/25, 16:08

  4. Markus Klein commented on patch set 2 06/18/25, 16:09

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 06/18/25, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80470

  6. Andreas Kienast commented on patch set 2 06/24/25, 09:46

    I'm undecided here. Using the already existing preview images may lead to broken thumbnails within the tooltip due to the required 1:1 aspect ratio.
  7. Markus Klein commented on patch set 2 06/24/25, 11:39

    Reply Unresolved

    Yes, but that really does not matter when we can save a processed file for every file in FAL! Please consider that being able to use the system is by far more important than a distorted thumbnail with 32px only used when dragging a file. With an S3 bucket, this patch combined with https://review.typo3.org/c/Packages/TYPO3.CMS/+/89755/ literally improves speed of loading a single folder by factor 5 on a production system (!!)
  8. Andreas Kienast commented on patch set 2 07/22/25, 08:40

    I still don't think this patch solves the issue properly, but introduces a workaround instead. The thumbnail is here so it can be used at various places within EXT:filelist (spoiler alert: I'm currently building a patch doing this). I checked the code yesterday – there is a `DeferredBackendImageProcessor` in place that offloads the generation into a separate PHP process if required, so it should not (tm) affect the initial rendering of the filelist. Honestly, I consider blurred / distorted figures being a degradation in _visual_ quality of our product.
  9. Markus Klein commented on patch set 2 07/22/25, 09:03

    Reply Unresolved

    We talked via Slack, just a few words to sum up my POV for others: I do not care about "visual quality" until the product actually does its job, which is the problem here. I have no better suggestion to "fix/workaround/..." this issue.
  10. Markus Klein abandoned the change 07/24/25, 13:48