Review main Merged

89760[TASK] Remove superfluous is_string() check

Chris Müller CR +2 V +2 Easy +2 −8 updated 06/19/25, 11:14

Commit message

The identifier argument has already a string type declaration, so
there is no need to check for a string again.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Chris Müller uploaded patch set 1 06/18/25, 17:18

  2. core-ci voted on patch set 1 V -1 06/18/25, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80473

  3. Georg Ringer uploaded patch set 2 V -1 06/18/25, 19:19

  4. core-ci voted on patch set 2 V +1 06/18/25, 19:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80474

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 06/18/25, 21:55

  6. Oliver Klee voted on patch set 2 CR +1 V +1 06/19/25, 11:01

  7. Benjamin Franzke voted on patch set 2 CR +2 V +2 06/19/25, 11:08

  8. Benjamin Franzke merged patch set 3 06/19/25, 11:14