89774[BUGFIX] Ensure FlexFormTools reset state of injected TcaMigration
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Oli Bartsch +1
- Markus Klein +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1621
-
Garvin Hicking uploaded patch set 1 06/19/25, 08:31
-
Garvin Hicking uploaded patch set 2 06/19/25, 08:33
-
core-ci voted on patch set 1 V -1 06/19/25, 08:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80496
-
core-ci voted on patch set 2 V +1 06/19/25, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80497
-
Oliver Klee updated the commit message in patch set 3
V +106/19/25, 10:48 -
core-ci voted on patch set 3 V +1 06/19/25, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80500
-
Benjamin Franzke commented on patch set 3 CR -1 06/19/25, 11:05
TcaMigration.php:118I'd prefer to initialize messages to an empty array within `migrate()`, there is no good usecase where multiple `migrate()` calls should "collect" messages… This ensures that this "mistake" does not happen again, when `TcaMigration` is used as a service. And `getMessage()` is annotated with "Can be used for deprecation messages after migrate() was called", that means it's clear the messages should refer to the last migration. (And of course it would have been better to return the messages as a result of `migrate()`, but that's another story…) -
Garvin Hicking commented on patch set 3 06/19/25, 12:00
TcaMigration.php:112ReplyYes, auto-spelling complete got to me. I meant successive, thanks.TcaMigration.php:118ReplyUnderstood. I was not sure of possible scenarios this collection might be wanted. I can rework this and adapt tests. -
Garvin Hicking uploaded patch set 4
CR -1V +106/19/25, 18:50 -
core-ci voted on patch set 4 V -1 06/19/25, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80506
-
Garvin Hicking uploaded patch set 5
V -106/19/25, 19:00 -
Garvin Hicking commented on patch set 5 06/19/25, 19:03
Reworked patch. Logged deprecations before and after the patch can be viewed here: https://gist.github.com/garvinhicking/e10e07f0e40dccdda726c8b61b505cffTcaMigration.php:112ReplyDoneTcaMigration.php:118ReplyDone -
core-ci voted on patch set 5 V +1 06/19/25, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80507
-
Markus Klein voted on patch set 5 CR +1 06/20/25, 05:44
-
Benjamin Franzke voted on patch set 5 CR +1 V +1 06/20/25, 07:32
-
Oli Bartsch commented on patch set 5 06/20/25, 08:26
Can we not just make the service non shared? `#[Autoconfigure(public: true, shared: false)]` -
Garvin Hicking commented on patch set 5 06/20/25, 09:08
Reply
No, because the FlexFormTools service re-uses the single service. It's not about other injection cases that let the messages bleed, but reuse of the same instance. So the other way would only be to remove the class from being injected at all, and use a "GU:mI()" every time. -
Oli Bartsch commented on patch set 5 CR +1 V +1 06/23/25, 09:22
Reply
ACK -
Christian Kuhn voted on patch set 5 CR +2 V +2 06/23/25, 10:05
-
Christian Kuhn commented on patch set 5 06/23/25, 10:20
my bad. i should have seen this with #104268 -
Christian Kuhn merged patch set 6 06/23/25, 10:50
TcaMigration.php:112