Review main Merged

89776[TASK] Remove superfluous todo in AbstractCompositeValidator

Torben Hansen CR +2 V +2 Easy +0 −8 updated 06/23/25, 17:26

Commit message

The todo for the property `$validatedInstancesContainer` will
not be resolved in the described way, because it would
introduce a constructor in an abstract (see discussion in
change #106847). The todo is therefore removed with this
change.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Torben Hansen uploaded patch set 1 06/19/25, 13:03

  2. Benjamin Franzke commented on patch set 1 06/19/25, 13:06

    next line of commit message was truncated by `git commit`, probably because you started with a forge issue at column 1, and was therefore interpreted as a comment. Can you add it again?
  3. core-ci voted on patch set 1 V +1 06/19/25, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80503

  4. Torben Hansen updated the commit message in patch set 2 V +1 06/19/25, 13:44

  5. Torben Hansen commented on patch set 1 06/19/25, 13:44

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 06/19/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80505

  7. Oliver Klee voted on patch set 2 CR +1 V +1 06/19/25, 14:10

  8. Elias Häußler voted on patch set 2 CR +1 V +1 06/23/25, 16:08

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 06/23/25, 17:26

  10. Stefan Bürk merged patch set 3 06/23/25, 17:26