Review main Abandoned

89778[FEATURE] Introduce PSR-14 event to modify new versioned copy

Amir Arends CR 0 V 0 Easy +46 −1 updated 10/07/26, 11:43

Commit message

Localized records in workspaces referenced the live parent record
instead of the workspace version, causing translated records to
disappear after being moved.

A new PSR-14 event (`BeforeRecordVersioningEvent`) now allows
developers to adjust the `transOrigPointerField` (e.g. `l18n_parent`)
before the record is versioned.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 1621

  1. Amir Arends uploaded patch set 1 06/20/25, 09:02

  2. Amir Arends uploaded patch set 2 06/20/25, 09:08

  3. Sebastian Michaelsen voted on patch set 2 CR +1 06/20/25, 09:09

  4. core-ci voted on patch set 1 V -1 06/20/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80526

  5. core-ci voted on patch set 2 V -1 06/20/25, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80527

  6. Amir Arends uploaded patch set 3 CR +1 V -1 06/20/25, 09:33

  7. core-ci voted on patch set 3 V +1 06/20/25, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80528

  8. Sebastian Michaelsen voted on patch set 3 CR +1 06/20/25, 09:43

  9. Georg Ringer commented on patch set 3 06/22/25, 09:19

    If it is a feature, it requires a feature rst and is only for main branch. However why not fixing the behavior?
  10. Oliver Klee updated the commit message in patch set 4 CR +1 V +1 06/22/25, 11:53

  11. core-ci voted on patch set 4 V +1 06/22/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80563

  12. Andreas Kienast commented on patch set 4 06/23/25, 06:45

    Reply Unresolved

    This – and DataHandler currently still uses hooks, therefore I wouldn't introduce events until further notice.
  13. Christian Kuhn commented on patch set 4 CR -1 06/23/25, 12:47

    hey. i looked at this and added some information to the issue. imho, this is a broken core behavior so devs shouldn't fix this in a hook, but core should be fixed instead. as such, i think, the proposed change isn't an approach we should continue to follow. i'll now create an own patch to create a scenario test for the current behavior. we can then have a look at it and decide on how to deal with the situation: i currently lean towards updating l18n_parent of the localized record as soon as the overlay of the default language record is created, but i'm not yet 100% sure about this since it may have impact during "partial publishing", we'ell see. i'd keep the patch open for a while to see what my approach comes up with.
  14. Christian Kuhn commented on patch set 4 06/23/25, 18:12

    ok, this turns out to be quite tricky. * Created https://review.typo3.org/c/Packages/TYPO3.CMS/+/89799 as pre-patch. * Created https://review.typo3.org/c/Packages/TYPO3.CMS/+/89803 as another pre-patch (currently still WIP). It turns out l10n_parent of localized records point to the default language LIVE record when records are changed, but point to the default language WORKSPACE record when moved. The issue itself is then "just" a follow-up since l10n_parent is then not updated when a "changed" overlay is turned into a "moved" overlay. I think we'll have to sort out what is correct. I'll communicate with benni on this.
  15. Garvin Hicking updated the commit message in patch set 5 CR -1 V +1 07/26/25, 19:21

  16. core-ci voted on patch set 5 V +1 07/26/25, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82361

  17. Markus Klein commented on patch set 5 03/19/26, 12:09

    Reply

    The pre-patches are merged now. Is this then resolved?
  18. Markus Klein commented on patch set 5 03/19/26, 14:21

    Reply

    Answering to myself: yes still a bug in current 13.4.27
  19. Christian Kuhn wrote 06/18/26, 23:06

    Removed reviewer Christian Kuhn.
  20. Benni Mack commented on patch set 5 10/02/26, 18:34

    Reply Unresolved

  21. Georg Ringer abandoned the change 10/07/26, 11:43