Review main Merged

89783[DOCS] Resolve rendering warnings EXT:lowlevel docs

Lina Wolf CR +2 V +2 Easy +5 −5 updated 06/23/25, 21:41

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Lina Wolf uploaded patch set 1 06/21/25, 07:06

  2. core-ci voted on patch set 1 V +1 06/21/25, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80550

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 06/22/25, 16:30

  4. Andreas Kienast commented on patch set 1 06/23/25, 07:20

    Where can I see those rendering warnings?
  5. Garvin Hicking commented on patch set 1 06/23/25, 08:34

    Reply

    Via: ``` alias render='docker run --rm --pull always -v ./:/project/ ghcr.io/typo3-documentation/render-guides:latest --no-progress --config=Documentation Documentation' cd typo3/sysext/lowlevel render ``` Current Output: ``` [2025-06-23T08:28:32.822270+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"ref","targetReference":"update-reference-index","value":"Update Reference Index","linkType":"std:label","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:32.824624+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"doc","targetReference":"Major/PreupgradeTasks/Index#with-command-line-recommended","value":"With command line (recommended)","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:32.824770+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"ref","targetReference":"update-reference-index","value":"check or update the reference index","linkType":"std:label","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:33.157645+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"ref","targetReference":"update-reference-index","value":"Update Reference Index","linkType":"std:label","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:33.157793+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"ref","targetReference":"update-reference-index","value":"Update Reference Index","linkType":"std:label","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:33.157983+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"doc","targetReference":"Major/PreupgradeTasks/Index#with-command-line-recommended","value":"With command line (recommended)","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:33.158093+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"doc","targetReference":"Major/PreupgradeTasks/Index#with-command-line-recommended","value":"With command line (recommended)","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:33.158281+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"ref","targetReference":"update-reference-index","value":"check or update the reference index","linkType":"std:label","interlinkDomain":"t3upgrade"} [] [2025-06-23T08:28:33.158429+00:00] app.WARNING: Inventory with key t3upgrade not found. {"rst-file":"BackendModules/DbCheck/ManageReferenceIndex","type":"ref","targetReference":"update-reference-index","value":"check or update the reference index","linkType":"std:label","interlinkDomain":"t3upgrade"} [] ``` Yes, we currently do not have a good core-docs rendering CI integration into runTests.sh which should catch this. I had initial talks with Stefan about this, but we didn't have time for it yet. I'll see what I can do about this.
  6. Garvin Hicking commented on patch set 1 06/23/25, 10:30

  7. Andreas Kienast commented on patch set 1 CR +1 06/23/25, 12:05

    Reply

    Acknowledged
  8. Georg Ringer voted on patch set 1 CR +1 V +1 06/23/25, 18:44

  9. Garvin Hicking voted on patch set 1 CR +2 V +2 06/23/25, 21:29

  10. Garvin Hicking merged patch set 2 06/23/25, 21:41