Review main Merged

89786[BUGFIX] Add global sorting dropdown for files

Andreas Kienast CR +2 V +2 Hard +252 −62 updated 06/24/25, 09:02

Commit message

In order to allow sorting files in tiles view, a consolidated sorting
dropdown button is introduced in the file list which is active in both
view modes.
The same sorting dropdown is applied to instances of Element Browser and
Link Browser as well.

To represent the sorting direction, a new enum `SortDirection` is
introduced for EXT:filelist and incorporated into existing code. The
render mode enum `Enum` is now able to return an array containing the
fields the file list can be ordered by.

The default sorting by "file" is changed to "name" as the column
"file" does not exist. Also, sorting by "RW" has been disabled as it
actively doesn't fulfill any purpose.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1419

  1. Andreas Kienast uploaded patch set 1 06/23/25, 09:03

  2. core-ci voted on patch set 1 V -1 06/23/25, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80581

  3. Andreas Kienast uploaded patch set 2 V -1 06/23/25, 10:55

  4. Andreas Kienast commented on patch set 2 06/23/25, 10:55

    FileList.php:109

    Albeit the class is internal, I'm not sure whether to keep this property for backward compatibility reasons.
  5. core-ci voted on patch set 2 V -1 06/23/25, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80597

  6. Andreas Kienast uploaded patch set 3 V -1 06/23/25, 12:03

  7. core-ci voted on patch set 3 V +1 06/23/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80604

  8. Andreas Kienast uploaded patch set 4 V +1 06/23/25, 12:36

  9. core-ci voted on patch set 4 V +1 06/23/25, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80607

  10. Oli Bartsch commented on patch set 4 V -1 06/23/25, 13:21

    Now, it's no longer possible to sort by selected columns. Please let's remove "rw" from sortable fields.
  11. Andreas Kienast uploaded patch set 5 V +1 06/23/25, 13:49

  12. Andreas Kienast commented on patch set 5 06/23/25, 13:50

    Reply

    Done
  13. core-ci voted on patch set 5 V +1 06/23/25, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80621

  14. Oli Bartsch commented on patch set 5 CR +1 V +1 06/23/25, 14:46

    FileList.php:109 Reply

    I'm in favour to keep this at least for v13
  15. Andreas Nedbal voted on patch set 5 CR +1 V +1 06/24/25, 07:39

  16. Andreas Kienast commented on patch set 5 CR -2 06/24/25, 08:31

    Waiting for Benjis Feedback
  17. Andreas Kienast voted on patch set 5 CR +2 V +2 06/24/25, 08:40

  18. Andreas Kienast merged patch set 6 06/24/25, 09:02

  19. Andreas Kienast commented on patch set 6 06/24/25, 09:02

    Reply

    Done

    FileList.php:109 Reply

    Done