Review main Merged

89788[BUGFIX] Set correct data-mode for file selection

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 07/28/25, 08:49

Commit message

Set data-mode to "file" in case "sys_file"
is to be selected in a TCA group field. This
prevents an empty record browser, which can
be tested with the group fields in
`tx_styleguide_elements_imagemanipulation`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 06/23/25, 10:08

  2. core-ci voted on patch set 1 V +1 06/23/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80586

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 06/23/25, 10:20

    Awesome, this bugged me for quite some time and I never got properly into it. Thanks! 😊
  4. Andreas Kienast voted on patch set 1 CR +1 V +1 06/23/25, 11:05

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 06/23/25, 12:24

  6. Oli Bartsch merged patch set 2 06/23/25, 12:24

  7. Markus Klein commented on patch set 2 07/28/25, 08:49

    Unresolved

    This is a regression fix to #98479 and must be added to v12 as well.