Review 13.4 Merged

89789[BUGFIX] Ensure FlexFormTools reset state of injected TcaMigration

Christian Kuhn CR +2 V +2 Easy +43 −1 updated 06/23/25, 10:50

Commit message

With #104268, `TcaMigration` is injected as a service into
`FlexFormTools` under the assumption that it is stateless.

However, the `$messages` property actually carries state and will
unnecessarily stack output messages from further runs.

This patch ensures the message stack gets reset on each run
of the `migrate()` method so the class can act as a proper
dependency-injected pseudo-stateless service.
An added test simulates this logic.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Christian Kuhn uploaded patch set 1 06/23/25, 10:18

  2. core-ci voted on patch set 1 V -1 06/23/25, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80591

  3. Oli Bartsch uploaded patch set 2 V -1 06/23/25, 10:38

  4. core-ci voted on patch set 2 V +1 06/23/25, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80593

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 06/23/25, 10:50

  6. Christian Kuhn merged patch set 3 06/23/25, 10:50