Review main Merged

89793[BUGFIX] Initialize change publishers for undefined form properties

Benjamin Franzke CR +2 V +2 Easy +12 −1 updated 07/24/25, 14:15

Commit message

The EXT:form model concept [1] sends change events (via
EXT:form `PublisherSubscriber`) whenever a property is changed
and uses these events for dirty-state tracking of the form editor
interface.

The interface can be used to edit existing properties, but also allows
to add new properties (like a description) to a form element, that
does not have a description yet.

Due to the nature of the form event model, these changes where not
detected, because changes to model object properties where only
"tracked" if they have a default value. Properties like
"elementDescription" do not have a default and therefore the
form element initialization now registers property change publishers
for all properties that can possibly be configured
by the form inspector (called "editors").

[1] https://docs.typo3.org/permalink/typo3-cms-form:concepts-formeditor-basicjavascriptconcepts-formelementmodel

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Benjamin Franzke uploaded patch set 1 06/23/25, 10:49

  2. core-ci voted on patch set 1 V +1 06/23/25, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80596

  3. Benjamin Franzke uploaded patch set 2 V +1 06/23/25, 12:35

  4. core-ci voted on patch set 2 V +1 06/23/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80606

  5. Garvin Hicking updated the commit message in patch set 3 V +1 06/23/25, 12:59

  6. core-ci voted on patch set 3 V +1 06/23/25, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80613

  7. Andreas Kienast commented on patch set 3 06/23/25, 14:34

    It seems you missed to add the reference in the commit message.
  8. Garvin Hicking updated the commit message in patch set 4 V +1 06/23/25, 16:21

  9. Garvin Hicking rebased onto patch set 5 06/23/25, 16:21

  10. Garvin Hicking commented on patch set 5 CR +1 V +1 06/23/25, 16:24

    This seems to work, I tested a few variations with and without changes and they were all properly detected.
  11. core-ci voted on patch set 4 V +1 06/23/25, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80645

  12. core-ci voted on patch set 5 V +1 06/23/25, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80646

  13. Benjamin Franzke commented on patch set 5 06/23/25, 18:12

    Reply

    Done
  14. Benni Mack voted on patch set 5 CR +1 V +1 07/24/25, 12:10

  15. Andreas Kienast voted on patch set 5 CR +1 V +1 07/24/25, 12:21

  16. Benjamin Franzke voted on patch set 5 CR +2 V +2 07/24/25, 13:34

  17. Benjamin Franzke merged patch set 6 07/24/25, 14:15