89794[TASK] Use data object for TCA processing
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/backend/Classes/Configuration/SiteTcaConfiguration.php+3 −3
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+3 −3
- typo3/sysext/core/Classes/Configuration/Tca/TcaFactory.php+3 −3
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php+277 −285
- typo3/sysext/core/Classes/Configuration/Tca/TcaProcessingResult.php14new+53 −0
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+58 −60
- typo3/sysext/install/Classes/Controller/UpgradeController.php+3 −3
Review log 2633
Show 68 earlier messages
-
Oli Bartsch uploaded patch set 1 06/23/25, 11:22
-
Christian Kuhn commented on patch set 1 06/23/25, 11:33
-
core-ci voted on patch set 1 V -1 06/23/25, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80600
-
Christian Kuhn commented on patch set 1 06/23/25, 11:49
TcaProcessingContext.php:25Reply->withAdditionalMessage() instead of ->addMessage() probably. -
Oli Bartsch uploaded patch set 2
V -106/23/25, 12:29 -
Oli Bartsch commented on patch set 2 06/23/25, 12:31
TcaProcessingContext.php:25ReplyDon't quite get it. The idea of the DO is to be enriched. So why should we make it immutable then? -
core-ci voted on patch set 2 V +1 06/23/25, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80605
-
Oli Bartsch uploaded patch set 3
V +106/23/25, 13:11
-
Oli Bartsch commented on patch set 3 06/23/25, 13:12
TcaProcessingContext.php:25ReplyYou might want to check current solution which uses the DO just as result, so it is immutable / readonly. -
core-ci voted on patch set 3 V +1 06/23/25, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80614
-
Christian Kuhn commented on patch set 3 CR -1 06/23/25, 13:35
when you add a DO for this, we should harden it as much as we can, there is no true benefit otherwise. let's talk about his change in case you want to push this forward. -
Benjamin Franzke commented on patch set 3 06/23/25, 14:12
TcaProcessingResult.php:20It is used by `TcaMigration` and the `migrate()` method, maybe `TcaMigrationResult` is a better fit?TcaProcessingResult.php:20Please mark `@internal` -
Oli Bartsch uploaded patch set 4
CR -1V +106/23/25, 14:25 -
core-ci voted on patch set 4 V +1 06/23/25, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80628
-
Oli Bartsch uploaded patch set 5
V +106/23/25, 14:48 -
Oli Bartsch commented on patch set 4 06/23/25, 14:49
TcaProcessingResult.php:20ReplyThe idea is to keep this data object generic so it can be used for other tca processor services, e.g. TcaPreparation as well.TcaProcessingResult.php:20ReplyDone -
Oli Bartsch commented on patch set 5 06/23/25, 14:49
TcaProcessingContext.php:25ReplyDone -
core-ci voted on patch set 5 V +1 06/23/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80635
-
Christian Kuhn commented on patch set 5 06/23/25, 19:08
TcaProcessingResult.php:36@return string[] could be a useful annotation here.TcaProcessingResult.php:46let's make this withAdditionalMessage(string $message) to harden this (you for example can't submit an array with objects anymore), and it bows to the usage which (always?) only creates a new object with a single additional message. -
Stefan Bürk commented on patch set 5 06/23/25, 19:46
TcaProcessingResult.php:46Reply``` withAdditionalMessages(string ...$messages): TcaProcessingResult ``` would be a good compromise .. type safe and can be used with an array of strings ... https://onlinephp.io/c/7eafa ``` withAdditionalMessages(...array_values($messages)) ``` -
Oli Bartsch uploaded patch set 6
V +106/23/25, 20:53 -
Oli Bartsch commented on patch set 5 06/23/25, 20:53
TcaProcessingResult.php:36ReplyDoneTcaProcessingResult.php:46ReplyDone -
core-ci voted on patch set 6 V +1 06/23/25, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80662
-
Christian Kuhn commented on patch set 6 06/23/25, 22:25
TcaProcessingResult.php:46Replythx. great idea. -
Christian Kuhn commented on patch set 6 06/23/25, 22:26
looks good to me now. i'll let it sink in for a day and will probably upvote soon. -
Stefan Bürk commented on patch set 6 06/24/25, 09:00
TcaProcessingResult.php:46```suggestion return new self($tca, $this->messages); ``` `new $this` looks weired .. but seems to work. Should we still change it to the more casual known `new self()` instead ?TcaProcessingResult.php:51```suggestion return new self($this->tca, array_merge($this->messages, $messages)); ``` see comment above -
Oli Bartsch uploaded patch set 7
V +106/24/25, 09:13 -
Oli Bartsch commented on patch set 7 06/24/25, 09:14
TcaProcessingResult.php:46ReplyDoneTcaProcessingResult.php:51ReplyDone -
core-ci voted on patch set 7 V +1 06/24/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80707
-
Stefan Bürk voted on patch set 7 CR +1 V +1 06/24/25, 09:29
-
Christian Kuhn voted on patch set 7 CR +1 V +1 06/24/25, 15:18
-
Oli Bartsch voted on patch set 7 CR +2 V +2 06/24/25, 15:28
-
Oli Bartsch merged patch set 8 06/24/25, 15:28
TcaProcessingContext.php:25