Review main Abandoned

89796[BUGFIX] Correctly check metadata permissions deleting a record

Albrecht Köhnlein CR 0 V 0 Easy +9 −1 updated 03/31/26, 06:44

Commit message

Records of `sys_file_metadata` are not related to a page and permission handling works in a different way than permissions for other database tables.

Now, we check if an editor actually has access to the DB
table and this fileMetaData.

Note: There are no DataHandler tests for editor, which is why
this case is currently not covered by Functional Tests.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Albrecht Köhnlein uploaded patch set 1 06/23/25, 12:44

  2. Albrecht Köhnlein updated the commit message in patch set 2 06/23/25, 12:45

  3. core-ci voted on patch set 1 V +1 06/23/25, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80610

  4. core-ci voted on patch set 2 V +1 06/23/25, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80611

  5. Benni Mack updated the commit message in patch set 3 V +1 08/14/25, 05:55

  6. core-ci voted on patch set 3 V +1 08/14/25, 06:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83352

  7. Albrecht Köhnlein commented on patch set 3 08/14/25, 06:48

    This does not look like a full sentence to me. 🤔
  8. Benni Mack updated the commit message in patch set 4 V +1 08/14/25, 08:40

  9. core-ci voted on patch set 4 V +1 08/14/25, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/83363

  10. Albrecht Köhnlein commented on patch set 4 08/14/25, 12:38

    Reply

    Done
  11. Albrecht Köhnlein abandoned the change 03/31/26, 06:44

    Codebase changed when fixing https://forge.typo3.org/issues/108853 and this problem seems not to exist anymore.