Review 13.4 Merged

89797[BUGFIX] Avoid invalid events on initial render in property grid editor

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 06/23/25, 12:58

Commit message

With #106485 the proper "dirtyness" checks of editing forms in the
backend UI was impacted so it recognized every form as "dirty" in
case a "Email to sender" or "Email to receiver" finisher was added.
The was caused by `<typo3-form-property-grid-editor>` pushing the
`PropertyGridEditorUpdateEvent` to subscribers not only on change,
but also on initialization.

Ensure that an update event is only dispatched if the value
of the entries change, not when they are initially set.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 06/23/25, 12:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/23/25, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80612

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/23/25, 12:58

  4. Benjamin Franzke merged patch set 2 06/23/25, 12:58