Review main Merged

89803[TASK] Add more workspace related move and change tests

Christian Kuhn CR +2 V +2 Expert +1123 −0 updated 06/24/25, 10:55

Commit message

A lot of the "casual" or "simple" stuff is working with
workspaces nowadays. We however have various issues with
more complex chains like "first change a localized record
in workspaces, then move the default language record".

The patch adds a couple more tests to specify the current
state when such chains are done in workspaces.

There is one detail that seems to bite us in particular:
When a default language record that has localizations is
*modified* in workspaces, created overlays of localizations
point to the *live* record in l18n_parent/l10n_parent. But
when a default language record is *moved* in workspaces,
the localized overlays point to the *worspace* record in
l18n_parent/l10n_parent. This leads to issues when a
localized record is *first* modified and the default
language record is *then* moved, which changes the localized
record from modified to moved (which is correct), but does
not update l18n_parent/l10n_parent to the LIVE uid of the
default language record. We need to decide what is correct
here and have to adapt behavior with another patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 31

Show 11 more files

Review log 1523

  1. Christian Kuhn uploaded patch set 1 06/23/25, 14:25

  2. Christian Kuhn uploaded patch set 2 06/23/25, 14:27

  3. core-ci voted on patch set 1 V +1 06/23/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80626

  4. core-ci voted on patch set 2 V +1 06/23/25, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80630

  5. Christian Kuhn uploaded patch set 3 V +1 06/23/25, 15:06

  6. core-ci voted on patch set 3 V +1 06/23/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80637

  7. Christian Kuhn uploaded patch set 4 V +1 06/23/25, 17:19

  8. core-ci voted on patch set 4 V +1 06/23/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80651

  9. Christian Kuhn uploaded patch set 5 V +1 06/23/25, 18:06

  10. core-ci voted on patch set 5 V +1 06/23/25, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80652

  11. Christian Kuhn updated the commit message in patch set 6 V +1 06/23/25, 18:26

  12. core-ci voted on patch set 6 V +1 06/23/25, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80654

  13. Christian Kuhn updated the commit message in patch set 7 V +1 06/23/25, 18:41

  14. core-ci voted on patch set 7 V +1 06/23/25, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80655

  15. Benni Mack voted on patch set 7 CR +1 V +1 06/24/25, 06:25

  16. Stefan Bürk commented on patch set 7 CR -1 06/24/25, 09:28

    releases line missing ...
  17. Christian Kuhn updated the commit message in patch set 8 CR +1 V +1 06/24/25, 09:32

  18. Christian Kuhn commented on patch set 8 06/24/25, 09:32

    Reply

    Done
  19. Stefan Bürk voted on patch set 8 CR +1 V +1 06/24/25, 09:33

  20. core-ci voted on patch set 8 V +1 06/24/25, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80713

  21. Oli Bartsch voted on patch set 8 CR +1 V +1 06/24/25, 09:40

  22. Christian Kuhn voted on patch set 8 CR +2 V +2 06/24/25, 10:55

  23. Christian Kuhn merged patch set 9 06/24/25, 10:55